Skip to content

chore: Add mwaykole to owners for coverage in India TZ#1229

Merged
fege merged 2 commits intoopendatahub-io:mainfrom
dbasunag:owner_india_tz
Mar 17, 2026
Merged

chore: Add mwaykole to owners for coverage in India TZ#1229
fege merged 2 commits intoopendatahub-io:mainfrom
dbasunag:owner_india_tz

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag commented Mar 16, 2026

Pull Request

Summary

Related Issues

  • Fixes:
  • JIRA:

How it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Chores
    • Updated internal project governance and code review assignment configuration.

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
@dbasunag dbasunag requested a review from a team as a code owner March 16, 2026 18:24
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/verified', '/lgtm', '/hold', '/cherry-pick', '/wip', '/build-push-pr-image'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

📝 Walkthrough

Walkthrough

Addition of mwaykole to the OWNERS file as an approver and reviewer. Two entries added to administrative configuration with no code logic changes.

Changes

Cohort / File(s) Summary
OWNERS Configuration
OWNERS
Added mwaykole to approvers and reviewers lists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty—all sections contain only template placeholders with no actual content, rationale, or information filled in. Complete the Summary section explaining why mwaykole needs to be added. Link any related issues/tickets. Confirm testing approach or explain why none applies.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding mwaykole to the OWNERS file for India timezone coverage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@OWNERS`:
- Line 6: The OWNERS file currently grants approver rights to the identity
"mwaykole" without documented authorization; remove "mwaykole" from the
approvers list and instead add them to the reviewers section (or leave as
reviewer) pending recorded authorization (link an issue/ticket and maintainer
ack), so that approval privileges are only granted in a follow-up PR after
evidence is attached.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0a47f308-6cb7-4839-ba20-1573cbdbee8b

📥 Commits

Reviewing files that changed from the base of the PR and between 5e62a40 and b6b1477.

📒 Files selected for processing (1)
  • OWNERS

Comment thread OWNERS
Copy link
Copy Markdown
Contributor

@fege fege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fege fege merged commit 227c907 into opendatahub-io:main Mar 17, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

@dbasunag dbasunag deleted the owner_india_tz branch March 19, 2026 00:07
ssaleem-rh pushed a commit to ssaleem-rh/opendatahub-tests that referenced this pull request Mar 23, 2026
…o#1229)

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
Co-authored-by: Milind Waykole <mwaykole@redhat.com>
Signed-off-by: Shehan Saleem <ssaleem@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants