Skip to content

fix: remove polarion marker since we don't use polarion#1281

Merged
threcc merged 3 commits intoopendatahub-io:mainfrom
dbasunag:polarion
Mar 24, 2026
Merged

fix: remove polarion marker since we don't use polarion#1281
threcc merged 3 commits intoopendatahub-io:mainfrom
dbasunag:polarion

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag commented Mar 23, 2026

Pull Request

Summary

Related Issues

  • Fixes:
  • JIRA:

How it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Chores
    • Removed test categorization markers from pytest configuration and multiple test files to streamline testing infrastructure.

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
@dbasunag dbasunag requested review from a team, mwaykole and threcc as code owners March 23, 2026 21:49
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/cherry-pick', '/hold', '/lgtm', '/verified', '/build-push-pr-image', '/wip'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2e37e41-c5e5-467b-adda-a0b559628759

📥 Commits

Reviewing files that changed from the base of the PR and between 70a5608 and 225b103.

📒 Files selected for processing (4)
  • pytest.ini
  • tests/model_serving/model_server/kserve/authentication/test_non_admin_users.py
  • tests/model_serving/model_server/kserve/observability/test_model_metrics.py
  • tests/model_serving/model_server/kserve/platform/test_model_serving_components.py
💤 Files with no reviewable changes (4)
  • tests/model_serving/model_server/kserve/platform/test_model_serving_components.py
  • pytest.ini
  • tests/model_serving/model_server/kserve/observability/test_model_metrics.py
  • tests/model_serving/model_server/kserve/authentication/test_non_admin_users.py

📝 Walkthrough

Walkthrough

This change removes pytest marker declarations for Polarion test ID tracking from the pytest configuration and across four test files, eliminating the marker definition and all references to Polarion-tagged tests.

Changes

Cohort / File(s) Summary
Pytest Configuration
pytest.ini
Removed polarion marker declaration from pytest markers.
Test Marker Removals
tests/model_serving/model_server/kserve/authentication/test_non_admin_users.py, tests/model_serving/model_server/kserve/observability/test_model_metrics.py, tests/model_serving/model_server/kserve/platform/test_model_serving_components.py
Removed @pytest.mark.polarion(...) annotations from six test methods across three files; no test logic altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely unfilled template boilerplate with no substantive information about the changes, rationale, testing, or related issues. Fill in the Summary section with details about why polarion markers are being removed, confirm testing approach, and document any related issues or tickets.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the polarion marker because it is unused.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@mwaykole mwaykole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had a tickets to for all cleanup for model server :(
/lgtm

@threcc threcc merged commit f6eb75b into opendatahub-io:main Mar 24, 2026
11 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants