fix: remove pgvector postStart lifecycle hook that leaked password in logs#1308
Conversation
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/cherry-pick', '/verified', '/lgtm', '/hold', '/wip', '/build-push-pr-image'} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Actionable Issues
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bobbins228
left a comment
There was a problem hiding this comment.
/lgtm nice catch thanks Ignas
… logs The pgvector image now auto-enables the vector extension, making the postStart hook unnecessary. This also eliminates the plaintext PGPASSWORD leak in test logs. Signed-off-by: Ignas Baranauskas <ibaranau@redhat.com>
cdf6210 to
8047833
Compare
ChristianZaccaria
left a comment
There was a problem hiding this comment.
/LGTM if the tests don't actually exercise vector similarity search. In that case, removing the lifecycle hook fixes the password leak with no functional impact. Worth double-checking that PGVector isn't used for vector search in our tests.
ChristianZaccaria
left a comment
There was a problem hiding this comment.
/lgtm /approve
|
Status of building tag latest: success. |
The pgvector image now auto-enables the vector extension, making the postStart hook unnecessary. This also eliminates the plaintext PGPASSWORD leak in test logs.
Pull Request
Summary
Related Issues
Please review and indicate how it has been tested
Additional Requirements
Summary by CodeRabbit