Skip to content

Add new test for Raw routs reconciliation#201

Merged
mwaykole merged 17 commits intoopendatahub-io:mainfrom
mwaykole:2ns-singel
Apr 1, 2025
Merged

Add new test for Raw routs reconciliation#201
mwaykole merged 17 commits intoopendatahub-io:mainfrom
mwaykole:2ns-singel

Conversation

@mwaykole
Copy link
Copy Markdown
Member

@mwaykole mwaykole commented Mar 26, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Add new test for Raw routs reconciliation
0eed4c2 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@mwaykole mwaykole requested a review from a team as a code owner March 26, 2025 16:41
@mwaykole mwaykole self-assigned this Mar 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/verified', '/hold', '/wip', '/lgtm'}

@mwaykole
Copy link
Copy Markdown
Member Author

mwaykole commented Mar 26, 2025

/Verified

@github-actions github-actions Bot added the Verified Verified pr in Jenkins label Mar 26, 2025
rnetser
rnetser suggested changes Mar 27, 2025
View reviewed changes
Comment thread tests/model_serving/model_server/conftest.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routs_reconciliation.py Outdated
@github-actions github-actions Bot added size/xl and removed Verified Verified pr in Jenkins size/l labels Mar 27, 2025
@mwaykole mwaykole force-pushed the 2ns-singel branch 2 times, most recently from 3549340 to 0eed4c2 Compare March 27, 2025 08:09
@github-actions github-actions Bot added size/l and removed size/xl labels Mar 27, 2025
pre-commit-ci Bot and others added 9 commits March 27, 2025 08:34
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4a4db00 
for more information, see https://pre-commit.ci
addressed comments
1bf852a 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
addressed comments on fail later
f6bb0f2 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8c463ed 
for more information, see https://pre-commit.ci
addressed comments on fail later
736f6cb 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
addressed comments on fail later
dfc5980 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8e6d585 
for more information, see https://pre-commit.ci
addressed comments new utils 3 test
e940ea3 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
addressed comments new utils 3 test
829c207 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@mwaykole
Copy link
Copy Markdown
Member Author

mwaykole commented Mar 27, 2025

/verified

@github-actions github-actions Bot added the Verified Verified pr in Jenkins label Mar 27, 2025
@mwaykole
Copy link
Copy Markdown
Member Author

mwaykole commented Mar 28, 2025

/verified

rnetser
rnetser previously approved these changes Mar 28, 2025
View reviewed changes
Comment thread tests/model_serving/model_server/raw_deployment/test_kserve_raw_routes_reconciliation.py Outdated
addressed comments for args=value
c1bba68 
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@github-actions github-actions Bot removed the Verified Verified pr in Jenkins label Mar 28, 2025
@mwaykole mwaykole enabled auto-merge (squash) March 28, 2025 13:14
@mwaykole mwaykole requested a review from rnetser March 28, 2025 13:57
@mwaykole mwaykole merged commit 7603d73 into opendatahub-io:main Apr 1, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lugi0 lugi0 Awaiting requested review from lugi0

@adolfo-ab adolfo-ab Awaiting requested review from adolfo-ab

2 more reviewers

@nehachopra27 nehachopra27 nehachopra27 approved these changes

@rnetser rnetser rnetser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mwaykole mwaykole

Labels

size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mwaykole @nehachopra27 @rnetser