add runtime check for oauth in MR by lugi0 · Pull Request #381 · opendatahub-io/opendatahub-tests

lugi0 · 2025-06-26T11:05:58Z

Description

How Has This Been Tested?

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

Signed-off-by: lugi0 <lgiorgi@redhat.com>

coderabbitai · 2025-06-26T11:06:25Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-26T11:08:54Z

The following are automatically added/executed:

PR size label.
Run pre-commit
Run tox
Add PR author as the PR assignee
Build image based on the PR

Available user actions:

To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
lgtm label removed on each new commit push.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/verified', '/lgtm', '/cherry-pick', '/wip', '/hold', '/build-push-pr-image'}

fege · 2025-06-26T11:29:12Z

            mr.wait_for_condition(condition="Available", status="True")
-            mr.wait_for_condition(condition="OAuthProxyAvailable", status="True")
+            if is_model_registry_oauth or get_product_version(admin_client=admin_client) >= Version.parse(
+                version="2.22.0"


should we use a constant for the version number?

fege

/lgtm

dbasunag · 2025-06-26T12:44:41Z

 @pytest.fixture(scope="class")
-def is_model_registry_oauth(request: FixtureRequest) -> bool:
-    return getattr(request, "param", {}).get("use_oauth_proxy", True)
+def is_model_registry_oauth(request: FixtureRequest, get_product_version: Version, admin_client: DynamicClient) -> bool:


We should not change this. It should be based on request.param and main is aligned with 2.23, so it should always be oauth.

dbasunag · 2025-06-26T12:45:23Z

        ) as mr:
            mr.wait_for_condition(condition="Available", status="True")
-            mr.wait_for_condition(condition="OAuthProxyAvailable", status="True")
+            if is_model_registry_oauth or get_product_version(admin_client=admin_client) >= Version.parse(


Main is now pointing to 2.23. We should not work around testops image tag issue. They need to prioritize and fix it. We should not sign off otherwise.

dbasunag

We should not do this. Branch was cut for 2.22. Now main is aligned with 2.23 and any older releases can't be qualified with latest tag.

dbasunag · 2025-06-30T17:12:37Z

Berto's PR is now merged. We no longer need this.

dbasunag · 2025-08-09T01:48:28Z

Closing as this is no longer relevant.

feat: add runtime check for oauth

b9f89ca

Signed-off-by: lugi0 <lgiorgi@redhat.com>

github-actions bot added ModelRegistry size/xs labels Jun 26, 2025

github-actions bot assigned lugi0 Jun 26, 2025

fege reviewed Jun 26, 2025

View reviewed changes

fege approved these changes Jun 26, 2025

View reviewed changes

rhods-ci-bot added commented-by-fege lgtm-by-fege labels Jun 26, 2025

dbasunag reviewed Jun 26, 2025

View reviewed changes

dbasunag requested changes Jun 26, 2025

View reviewed changes

rhods-ci-bot added the commented-by-dbasunag label Jun 26, 2025

dbasunag closed this Aug 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add runtime check for oauth in MR#381

add runtime check for oauth in MR#381
lugi0 wants to merge 1 commit intoopendatahub-io:mainfrom
lugi0:feat/oauth-dynamic-check

lugi0 commented Jun 26, 2025

Uh oh!

coderabbitai bot commented Jun 26, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

fege Jun 26, 2025

Uh oh!

fege left a comment

Uh oh!

dbasunag Jun 26, 2025

Uh oh!

dbasunag Jun 26, 2025

Uh oh!

dbasunag left a comment

Uh oh!

dbasunag commented Jun 30, 2025

Uh oh!

dbasunag commented Aug 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lugi0 commented Jun 26, 2025

Description

How Has This Been Tested?

Merge criteria:

Uh oh!

coderabbitai bot commented Jun 26, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

fege Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

fege left a comment

Choose a reason for hiding this comment

Uh oh!

dbasunag Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

dbasunag Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

dbasunag left a comment

Choose a reason for hiding this comment

Uh oh!

dbasunag commented Jun 30, 2025

Uh oh!

dbasunag commented Aug 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants