refactor: update MinIO digest and improve readability#645
refactor: update MinIO digest and improve readability#645sheltoncyril wants to merge 2 commits intoopendatahub-io:mainfrom
Conversation
📝 WalkthroughWalkthroughUpdated constants in utilities/constants.py: new image SHA for MODEL_MESH_MINIO_CONFIG; restructured RunTimeConfig vLLM_CONFIG port fields from single dicts to lists of dicts (grpc and raw ports); reformatted QWENCHAT CHAT_GENERATION_CONFIG.service from flat dict to a nested multi-line dict with identical keys. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/build-push-pr-image', '/hold', '/cherry-pick', '/verified', '/lgtm'} |
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit