Skip to content

refactor: update MinIO digest and improve readability#645

Closed
sheltoncyril wants to merge 2 commits intoopendatahub-io:mainfrom
sheltoncyril:modelmesh-minio-image-patch
Closed

refactor: update MinIO digest and improve readability#645
sheltoncyril wants to merge 2 commits intoopendatahub-io:mainfrom
sheltoncyril:modelmesh-minio-image-patch

Conversation

@sheltoncyril
Copy link
Copy Markdown
Contributor

@sheltoncyril sheltoncyril commented Sep 25, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • New Features
    • None
  • Refactor
    • Standardized runtime port configurations for gRPC and raw ports to a consistent list-based format.
    • Reformatted QWENCHAT service configuration for clearer structure.
  • Chores
    • Updated container image reference for MinIO configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 25, 2025

📝 Walkthrough

Walkthrough

Updated constants in utilities/constants.py: new image SHA for MODEL_MESH_MINIO_CONFIG; restructured RunTimeConfig vLLM_CONFIG port fields from single dicts to lists of dicts (grpc and raw ports); reformatted QWENCHAT CHAT_GENERATION_CONFIG.service from flat dict to a nested multi-line dict with identical keys.

Changes

Cohort / File(s) Summary
Config and port schema updates
utilities/constants.py
Updated MODEL_MESH_MINIO_CONFIG image SHA. Restructured vLLM_CONFIG ports: grpc converted to list with containerPort/name/protocol; raw ports expanded into a list of two dicts with containerPort/name/protocol. Reformatted QWENCHAT CHAT_GENERATION_CONFIG.service to a nested multi-line dict (hostname, port, request_timeout unchanged).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly highlights the primary update to the MinIO image digest and notes the secondary goal of improving readability, which aligns with the actual changes to constants and configuration formatting in the PR. It is clear, specific, and free of unnecessary detail or vague terminology.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6265ddf and bb0f3b4.

📒 Files selected for processing (1)
  • utilities/constants.py (3 hunks)
🔇 Additional comments (1)
utilities/constants.py (1)

344-361: No dict-based port accesses remain Only container["ports"] is assigned the new list format in serving_runtime.py; there are no calls indexing into containerPort.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sheltoncyril sheltoncyril marked this pull request as ready for review September 25, 2025 18:40
@sheltoncyril sheltoncyril requested a review from a team as a code owner September 25, 2025 18:40
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/wip', '/build-push-pr-image', '/hold', '/cherry-pick', '/verified', '/lgtm'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant