Skip to content

RHOAIENG-16055: new(tests): test to start a Workbench, by creating the Notebook CR directly#94

Merged
rnetser merged 1 commit intoopendatahub-io:mainfrom
jiridanek:jd_notebooks_first
Mar 23, 2025
Merged

RHOAIENG-16055: new(tests): test to start a Workbench, by creating the Notebook CR directly#94
rnetser merged 1 commit intoopendatahub-io:mainfrom
jiridanek:jd_notebooks_first

Conversation

@jiridanek
Copy link
Copy Markdown
Member

@jiridanek jiridanek commented Jan 15, 2025 •
edited
Loading

Description

This is a port of

Based on the change in

How Has This Been Tested?

  • figure out when/how to use unprivileged k8s client
  • test passed with RHOAI 2.19 nightly

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek marked this pull request as draft January 15, 2025 17:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 15, 2025

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/hold', '/verified', '/lgtm', '/wip'}

@jiridanek jiridanek marked this pull request as ready for review January 17, 2025 09:27
@github-actions github-actions Bot added size/xl and removed size/xxl labels Jan 17, 2025
@jiridanek jiridanek force-pushed the jd_notebooks_first branch 2 times, most recently from f5edaa0 to c1eddd8 Compare January 17, 2025 09:49
rnetser
rnetser suggested changes Jan 19, 2025
View reviewed changes
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_data/notebook.yaml Outdated
lugi0
lugi0 reviewed Jan 20, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/docs.py Outdated
Comment thread tests/workbenches/conftest.py
@jiridanek jiridanek force-pushed the jd_notebooks_first branch 3 times, most recently from b956376 to bf53997 Compare February 4, 2025 08:57
@jiridanek jiridanek requested a review from rnetser February 4, 2025 08:58
@jiridanek jiridanek force-pushed the jd_notebooks_first branch 3 times, most recently from 12f966f to 21ee191 Compare February 4, 2025 09:24
lugi0
lugi0 reviewed Feb 7, 2025
View reviewed changes
Comment thread tests/workbenches/docs.py Outdated
Comment thread tests/workbenches/resources.py Outdated
Comment thread tests/workbenches/utils.py Outdated
Comment thread tests/workbenches/utils.py Outdated
Comment thread utilities/infra.py Outdated
adolfo-ab
adolfo-ab reviewed Feb 7, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_data/notebook.yaml Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/resources.py Outdated
rnetser
rnetser suggested changes Feb 10, 2025
View reviewed changes
Comment thread tests/workbenches/conftest.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py
Comment thread tests/workbenches/conftest.py
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/utils.py Outdated
Comment thread tests/workbenches/utils.py Outdated
Comment thread utilities/constants.py Outdated
@jiridanek jiridanek requested a review from a team as a code owner February 24, 2025 10:25
mwaykole
mwaykole reviewed Feb 24, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
mwaykole
mwaykole reviewed Feb 24, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
@jiridanek jiridanek force-pushed the jd_notebooks_first branch 2 times, most recently from f404037 to 6e68377 Compare February 24, 2025 12:16
@jiridanek jiridanek requested a review from rnetser February 24, 2025 12:32
@github-actions github-actions Bot added the Verified Verified pr in Jenkins label Mar 18, 2025
lugi0
lugi0 reviewed Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit of a nitpick, otherwise it looks good to me. I see #184 pushing some of the bits here, so not sure if this needs a rebase before merging.

Comment thread tests/workbenches/conftest.py
@github-actions github-actions Bot added size/l and removed Verified Verified pr in Jenkins size/xl labels Mar 19, 2025
@jiridanek
Copy link
Copy Markdown
Member Author

jiridanek commented Mar 19, 2025

/verified

@rnetser @lugi0 rebased, should be ready!

@github-actions github-actions Bot added the Verified Verified pr in Jenkins label Mar 19, 2025
rnetser
rnetser suggested changes Mar 20, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
@jiridanek
Copy link
Copy Markdown
Member Author

jiridanek commented Mar 20, 2025

/verified

@github-actions github-actions Bot added Verified Verified pr in Jenkins and removed Verified Verified pr in Jenkins labels Mar 20, 2025
@jiridanek jiridanek requested a review from rnetser March 20, 2025 15:03
rnetser
rnetser suggested changes Mar 20, 2025
View reviewed changes
Comment thread tests/workbenches/notebook-controller/test_spawning.py Outdated
@jiridanek
Copy link
Copy Markdown
Member Author

jiridanek commented Mar 20, 2025

/verified

@github-actions github-actions Bot added Verified Verified pr in Jenkins and removed Verified Verified pr in Jenkins labels Mar 20, 2025
@jiridanek jiridanek requested a review from rnetser March 20, 2025 15:49
mwaykole
mwaykole reviewed Mar 20, 2025
View reviewed changes
Comment thread tests/workbenches/conftest.py
@jiridanek
Copy link
Copy Markdown
Member Author

jiridanek commented Mar 21, 2025

/verified

lugi0
lugi0 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot removed the Verified Verified pr in Jenkins label Mar 23, 2025
@jiridanek jiridanek force-pushed the jd_notebooks_first branch from 1958d8c to 8b16a2a Compare March 23, 2025 10:23
@jiridanek
Copy link
Copy Markdown
Member Author

jiridanek commented Mar 23, 2025

/verified

@github-actions github-actions Bot added the Verified Verified pr in Jenkins label Mar 23, 2025
@rnetser rnetser merged commit f2762f8 into opendatahub-io:main Mar 23, 2025
5 checks passed
@jiridanek jiridanek deleted the jd_notebooks_first branch March 23, 2025 17:21
@jiridanek jiridanek mentioned this pull request May 6, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwaykole mwaykole mwaykole left review comments

@jstourac jstourac jstourac approved these changes

@lugi0 lugi0 lugi0 approved these changes

+3 more reviewers

@myakove myakove myakove left review comments

@rnetser rnetser rnetser approved these changes

@adolfo-ab adolfo-ab adolfo-ab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commented-by-jiridanek commented-by-jstourac size/l Verified Verified pr in Jenkins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jiridanek @jstourac @myakove @mwaykole @rnetser @lugi0 @adolfo-ab