From 558d938ebbb8ad96ef54e15f6ba7fb0f948ba6bc Mon Sep 17 00:00:00 2001 From: dbasunag Date: Tue, 15 Apr 2025 11:50:10 -0400 Subject: [PATCH 1/2] on rebase clean commented-by- labels --- .github/workflows/scripts/pr_workflow.py | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/scripts/pr_workflow.py b/.github/workflows/scripts/pr_workflow.py index a5dd6634f..b9b5f8ab9 100644 --- a/.github/workflows/scripts/pr_workflow.py +++ b/.github/workflows/scripts/pr_workflow.py @@ -231,6 +231,7 @@ def add_remove_pr_labels(self) -> None: label.lower() == VERIFIED_LABEL_STR or label.lower().startswith(LGTM_BY_LABEL_PREFIX) or label.lower().startswith(CHANGED_REQUESTED_BY_LABEL_PREFIX) + or label.lower().startswith(COMMENTED_BY_LABEL_PREFIX) ): LOGGER.info(f"Removing label {label}") self.pr.remove_from_labels(label=label) From fe74e7623b9df326c4bc80c0c486512e4a9d421c Mon Sep 17 00:00:00 2001 From: dbasunag Date: Wed, 16 Apr 2025 17:38:11 -0400 Subject: [PATCH 2/2] remove unnecessary argument from function call --- tests/model_registry/conftest.py | 5 +---- tests/model_registry/utils.py | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/model_registry/conftest.py b/tests/model_registry/conftest.py index 6323c03e8..79feac33a 100644 --- a/tests/model_registry/conftest.py +++ b/tests/model_registry/conftest.py @@ -185,12 +185,9 @@ def model_registry_instance_service( @pytest.fixture(scope="class") def model_registry_instance_rest_endpoint( - admin_client: DynamicClient, model_registry_instance_service: Service, ) -> str: - return get_endpoint_from_mr_service( - client=admin_client, svc=model_registry_instance_service, protocol=Protocols.REST - ) + return get_endpoint_from_mr_service(svc=model_registry_instance_service, protocol=Protocols.REST) @pytest.fixture(scope="class") diff --git a/tests/model_registry/utils.py b/tests/model_registry/utils.py index 4282bbd6c..86341b5d8 100644 --- a/tests/model_registry/utils.py +++ b/tests/model_registry/utils.py @@ -40,7 +40,7 @@ def get_mr_service_by_label(client: DynamicClient, ns: Namespace, mr_instance: M raise ResourceNotFoundError(f"{mr_instance.name} has no Service") -def get_endpoint_from_mr_service(client: DynamicClient, svc: Service, protocol: str) -> str: +def get_endpoint_from_mr_service(svc: Service, protocol: str) -> str: if protocol in (Protocols.REST, Protocols.GRPC): return svc.instance.metadata.annotations[f"{ADDRESS_ANNOTATION_PREFIX}{protocol}"] else: