diff --git a/.flake8 b/.flake8 index a86631600..154002f91 100644 --- a/.flake8 +++ b/.flake8 @@ -28,8 +28,10 @@ fcn_exclude_functions = write, from_pytest_fixture, QueueListener, - yaml - + yaml, + add_to_assignees, + validate_inference_output, # TODO: function should be fixed to get rid of this + group enable-extensions = FCN, diff --git a/.github/workflows/scripts/pr_workflow.py b/.github/workflows/scripts/pr_workflow.py index b9b5f8ab9..bd255266b 100644 --- a/.github/workflows/scripts/pr_workflow.py +++ b/.github/workflows/scripts/pr_workflow.py @@ -107,7 +107,7 @@ def verify_allowed_user(self) -> None: team: Team = org.get_team_by_slug("opendatahub-tests-contributors") try: # check if the user is a member of opendatahub-tests-contributors - membership = team.get_team_membership(self.user_login) + membership = team.get_team_membership(member=self.user_login) LOGGER.info(f"User {self.user_login} is a member of the test contributor team. {membership}") except UnknownObjectException: LOGGER.error(f"User {self.user_login} is not allowed for this action. Exiting.") diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f31d0674e..86c96a5cd 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -22,7 +22,7 @@ repos: rev: "7.2.0" hooks: - id: flake8 - args: [--config=.flake8, '--ignore=FCN001,W503'] + args: [--config=.flake8] additional_dependencies: [ "git+https://github.com/RedHatQE/flake8-plugins.git@v0.0.6", diff --git a/tests/model_registry/python_client/test_model_registry_creation.py b/tests/model_registry/python_client/test_model_registry_creation.py index 83ff33cfc..8d249608a 100644 --- a/tests/model_registry/python_client/test_model_registry_creation.py +++ b/tests/model_registry/python_client/test_model_registry_creation.py @@ -55,7 +55,7 @@ def test_registering_model( model_registry_client: ModelRegistryClient, registered_model: RegisteredModel, ): - model = model_registry_client.get_registered_model(MODEL_NAME) + model = model_registry_client.get_registered_model(name=MODEL_NAME) expected_attrs = { "id": registered_model.id, "name": registered_model.name, diff --git a/tests/model_serving/model_server/raw_deployment/utils.py b/tests/model_serving/model_server/raw_deployment/utils.py index e7d86a74c..82e60b8a0 100644 --- a/tests/model_serving/model_server/raw_deployment/utils.py +++ b/tests/model_serving/model_server/raw_deployment/utils.py @@ -20,7 +20,7 @@ def assert_ingress_status_changed(admin_client: DynamicClient, inference_service Returns: None """ - route = get_model_route(admin_client, inference_service) + route = get_model_route(client=admin_client, isvc=inference_service) if not route.exists: raise ResourceNotFoundError("Route before deletion not found: No active route is currently available.") diff --git a/utilities/infra.py b/utilities/infra.py index b7f6a0084..cd3ed778b 100644 --- a/utilities/infra.py +++ b/utilities/infra.py @@ -727,7 +727,7 @@ def get_product_version(admin_client: DynamicClient) -> Version: if not operator_version: raise MissingResourceError("Operator ClusterServiceVersion not found") - return Version.parse(operator_version) + return Version.parse(version=operator_version) def get_dsci_applications_namespace(client: DynamicClient) -> str: diff --git a/utilities/jira.py b/utilities/jira.py index 4456d1695..db7fdb51a 100644 --- a/utilities/jira.py +++ b/utilities/jira.py @@ -67,7 +67,7 @@ def is_jira_open(jira_id: str, admin_client: DynamicClient) -> bool: if not operator_version: raise MissingResourceError("Operator ClusterServiceVersion not found") - csv_version = Version(operator_version) + csv_version = Version(version=operator_version) if all([csv_version < fix_version for fix_version in jira_fix_versions]): LOGGER.info( f"Bug is open: Jira {jira_id}: status is {jira_status}, "