Skip to content

Commit ef76c90

Browse files
committed
Review + update docs
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
1 parent 9f947f7 commit ef76c90

File tree

6 files changed

+7
-47
lines changed

6 files changed

+7
-47
lines changed

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ deploy-lws: check-kubeconfig clear-cache
5757
deploy-opendatahub-prerequisites: check-kubeconfig
5858
@echo "=== Deploying OpenDataHub prerequisites ==="
5959
kubectl create namespace $(KSERVE_NAMESPACE) --dry-run=client -o yaml | kubectl apply -f -
60-
-kubectl get secret redhat-pull-secret -n istio-system -o yaml 2>/dev/null | \
61-
sed 's/namespace: istio-system/namespace: $(KSERVE_NAMESPACE)/' | \
62-
kubectl apply -f - 2>/dev/null || true
6360

6461
deploy-cert-manager-pki: check-kubeconfig deploy-opendatahub-prerequisites
6562
@kubectl get crd clusterissuers.cert-manager.io >/dev/null 2>&1 || \

charts/kserve/templates/resources.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
apiVersion: v1
1212
kind: Secret
1313
metadata:
14-
name: {{ $.Values.pullSecret.name }}
14+
name: redhat-pull-secret
1515
namespace: {{ $ns }}
1616
type: kubernetes.io/dockerconfigjson
1717
data:
@@ -40,7 +40,7 @@ automountServiceAccountToken: {{ $resource.automountServiceAccountToken }}
4040
{{- end }}
4141
{{- if $.Values.pullSecret.dockerConfigJson }}
4242
imagePullSecrets:
43-
- name: {{ $.Values.pullSecret.name }}
43+
- name: redhat-pull-secret
4444
{{- range $resource.imagePullSecrets }}
4545
- name: {{ .name }}
4646
{{- end }}

charts/kserve/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@
55
# Pull secret for registry.redhat.io
66
# Auth is configured in the root values.yaml and passed via helmfile
77
pullSecret:
8-
name: redhat-pull-secret
98
dockerConfigJson: "" # Set automatically by helmfile from root auth config

docs/deploying-llm-d-on-managed-kubernetes.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,10 +514,6 @@ make deploy-kserve
514514
**Resolution:**
515515

516516
```bash
517-
kubectl get secret redhat-pull-secret -n istio-system -o json | \
518-
jq 'del(.metadata.resourceVersion, .metadata.uid, .metadata.creationTimestamp, .metadata.annotations, .metadata.labels) | .metadata.namespace = "opendatahub"' | \
519-
kubectl create -f -
520-
521517
kubectl patch sa inference-gateway-istio -n opendatahub \
522518
-p '{"imagePullSecrets": [{"name": "redhat-pull-secret"}]}'
523519

docs/gateway-setup-for-kserve.md

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,7 @@ GATEWAY_NAME=inference-gateway \
3838

3939
## Manual Setup
4040

41-
### Step 1: Copy Pull Secret
42-
43-
The Gateway pod needs to pull Istio images from `registry.redhat.io`:
44-
45-
```bash
46-
# Copy pull secret to opendatahub namespace
47-
kubectl delete secret redhat-pull-secret -n opendatahub --ignore-not-found
48-
kubectl get secret redhat-pull-secret -n istio-system -o json | \
49-
jq 'del(.metadata.resourceVersion, .metadata.uid, .metadata.creationTimestamp, .metadata.annotations, .metadata.labels) | .metadata.namespace = "opendatahub"' | \
50-
kubectl create -f -
51-
```
52-
53-
### Step 2: Extract CA and Create ConfigMap
41+
### Step 1: Extract CA and Create ConfigMap
5442

5543
```bash
5644
# Extract CA certificate from cert-manager secret
@@ -71,7 +59,7 @@ kubectl create configmap odh-ca-bundle \
7159
--dry-run=client -o yaml | kubectl apply -f -
7260
```
7361

74-
### Step 3: Create Gateway Configuration ConfigMap
62+
### Step 2: Create Gateway Configuration ConfigMap
7563

7664
This configures the Gateway pod to mount the CA bundle at the path expected by
7765
LLM workloads (`/var/run/secrets/opendatahub/ca.crt`).
@@ -101,7 +89,7 @@ data:
10189
EOF
10290
```
10391

104-
### Step 4: Create the Gateway
92+
### Step 3: Create the Gateway
10593

10694
```bash
10795
kubectl apply -f - <<'EOF'
@@ -129,7 +117,7 @@ spec:
129117
EOF
130118
```
131119

132-
### Step 5: Patch ServiceAccount and Restart Pod
120+
### Step 4: Patch ServiceAccount and Restart Pod
133121

134122
The Gateway ServiceAccount needs the pull secret to pull Istio images:
135123

@@ -147,7 +135,7 @@ kubectl wait --for=condition=Ready pod \
147135
-n opendatahub --timeout=120s
148136
```
149137

150-
### Step 6: Verify
138+
### Step 5: Verify
151139

152140
```bash
153141
# Check Gateway is programmed

scripts/setup-gateway.sh

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -172,25 +172,6 @@ EOF
172172
fi
173173
}
174174

175-
copy_pull_secret() {
176-
log_info "Copying pull secret to ${KSERVE_NAMESPACE}..."
177-
178-
# Check if pull secret exists in istio-system
179-
if ! kubectl get secret "${REDHAT_PULL_SECRET}" -n istio-system &>/dev/null; then
180-
log_error "Pull secret ${REDHAT_PULL_SECRET} not found in istio-system namespace"
181-
log_error "Run 'make deploy' first to deploy infrastructure with pull secret"
182-
return 1
183-
fi
184-
185-
# Delete existing secret to avoid conflicts, then create fresh copy
186-
kubectl delete secret "${REDHAT_PULL_SECRET}" -n "${KSERVE_NAMESPACE}" --ignore-not-found
187-
kubectl get secret "${REDHAT_PULL_SECRET}" -n istio-system -o yaml | \
188-
sed "s/namespace: istio-system/namespace: ${KSERVE_NAMESPACE}/" | \
189-
kubectl create -f -
190-
191-
log_success "Pull secret copied to ${KSERVE_NAMESPACE}"
192-
}
193-
194175
pull_secret_setup() {
195176
log_info "Patching ServiceAccount ${ISTIO_SERVICEACCOUNT} with pull secret..."
196177

@@ -278,7 +259,6 @@ main() {
278259
kubectl create namespace "${KSERVE_NAMESPACE}"
279260
fi
280261

281-
copy_pull_secret
282262
setup_ca_bundle
283263
create_gateway_config
284264
create_gateway

0 commit comments

Comments
 (0)