Skip to content

Commit 9e9f0e1

Browse files
authored
Merge pull request #86 from shruthis4/addCreds
Add Quay login step to Kustomize e2e workflow and inherit secrets in …
2 parents 28e9e4f + 0b0903c commit 9e9f0e1

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/_run-kustomize-e2e.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,14 @@ jobs:
6262
run: |
6363
make kind-create-cluster KIND_K8S_VERSION="${K8S_VERSION}" KIND_CLUSTER_NAME="${KIND_CLUSTER_NAME}"
6464
65+
- name: Log in to Quay
66+
if: ${{ env.MODE == 'local' }}
67+
uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121
68+
with:
69+
registry: quay.io
70+
username: ${{ secrets.AIPCC_BASE_IMAGE_USERNAME }}
71+
password: ${{ secrets.AIPCC_BASE_IMAGE_PASSWORD }}
72+
6573
- name: Build image with Make (MODE=local)
6674
if: ${{ env.MODE == 'local' }}
6775
shell: bash

.github/workflows/integration-odh.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@
1414
name: OpenShift/KIND ODH Spark Pi E2E (Kustomize)
1515

1616
on:
17-
pull_request:
18-
paths:
19-
- 'examples/openshift/**'
20-
- 'config/**'
21-
- '.github/workflows/integration-odh.yaml'
2217
push:
2318
branches: [main]
2419
paths:
@@ -47,8 +42,9 @@ jobs:
4742
matrix:
4843
arch: [amd64, arm64]
4944
uses: ./.github/workflows/_run-kustomize-e2e.yaml
45+
secrets: inherit
5046
with:
51-
mode: ${{ github.event_name == 'pull_request' && 'local' || (github.event_name == 'workflow_dispatch' && inputs.mode || 'repo') }}
47+
mode: ${{ github.event_name == 'workflow_dispatch' && inputs.mode || 'repo' }}
5248
dockerfile: examples/openshift/Dockerfile.odh
5349
full_image: quay.io/opendatahub/spark-operator:local
5450
kind_cluster_name: spark-operator

0 commit comments

Comments
 (0)