Skip to content

Commit bb15f98

Browse files
committed
fix: remove early returns blocking progression requeue
1 parent 011e4c0 commit bb15f98

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

pkg/controller/trainjob_controller.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,7 @@ func (r *TrainJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
150150
if !equality.Semantic.DeepEqual(&trainJob.Status, prevTrainJob.Status) {
151151
// TODO(astefanutti): Consider using SSA once controller-runtime client has SSA support
152152
// for sub-resources. See: https://github.com/kubernetes-sigs/controller-runtime/issues/3183
153-
if statusErr := r.client.Status().Patch(ctx, &trainJob, client.MergeFrom(prevTrainJob)); statusErr != nil {
154-
return ctrl.Result{}, errors.Join(err, statusErr)
155-
}
153+
return ctrl.Result{}, errors.Join(err, r.client.Status().Patch(ctx, &trainJob, client.MergeFrom(prevTrainJob)))
156154
}
157155

158156
// RHAI progression tracking

0 commit comments

Comments
 (0)