Auto sync dev to stable (up to 28a60bd7)#119
Merged
github-actions[bot] merged 2 commits intostablefrom Mar 20, 2026
Merged
Conversation
Add label-selector filtering on the controller-runtime informer cache so only resources carrying the operator-name label are cached. Without filtering, the cache loads all Pods, Services, ConfigMaps, and RBAC objects cluster-wide, causing unbounded memory growth under load. Changes: - Add newCacheOptions() with ByObject label selectors using "exists" requirement on the operator-name label - Strip managed fields from cached objects (TransformStripManagedFields) - Disable cache for ConfigMap and Secret client reads (DisableFor) - Add operator-name label to MPI controller resources (ConfigMap, ServiceAccount, Role, RoleBinding) that were missing it - Set GOMEMLIMIT=460MiB and add resource limits (512Mi) to deployment
Add Secret to the ByObject cache configuration with the same operator-name label filter used for other core types. While no controller currently creates a Secret informer, this prevents an unfiltered cluster-wide Secret watch if one is added in the future.
|
/approve |
Author
|
✅ Approved and merged! The stable branch has been fast-forwarded to point to the same commit as this temporary branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Sync from dev to stable
This PR automatically syncs the
devbranch to thestablebranch by creating a temporary branch directly from dev.Latest commit: 28a60bd - fix: Add Secret to ByObject label filter for defense-in-depth
Total commits to sync: 2
🚫 DO NOT use the GitHub merge button!
Once all checks are complete, comment
/approveon this PR to automatically fast-forward merge the stable branch to point to the same commit as this temporary branch.Only use the
/approvecommand - the GitHub merge button will not work correctly for this automated sync process.Pre-merge Checklist
Before approving this PR, please ensure the following tasks are completed:
podman build -f build/images/training-operator/Dockerfile.rhoai .), upload it to quayCommits to be synced:
This PR was created automatically by the sync workflow.