dropping namespaceSelector entirely (#43)

* dropping namespaceSelector entirely
* explicitly set empty string for watch namespace

Signed-off-by: greg pereira <grpereir@redhat.com>

Author: Gregory-Pereira

config/manager/manager.yaml

@@ -62,6 +62,8 @@ spec:
         args:
           - --leader-elect=true
           - --health-probe-bind-address=:8081
+          # set watch-namespace explicitly to empty string for consistent behaviour because of diverging defaults between upstream and midstream/downstream
+          - --watch-namespace=
           # Leader election timeout configuration (optional - defaults shown below)
           # Uncomment and adjust these values if you need to tune for your environment:
           # - --leader-election-lease-duration=60s

config/prometheus/monitor.yaml

@@ -22,6 +22,3 @@ spec:
     matchLabels:
       control-plane: controller-manager
       app.kubernetes.io/name: workload-variant-autoscaler
-  namespaceSelector:
-    matchNames:
-    - workload-variant-autoscaler-system

config/prometheus/servicemonitor.yaml

@@ -9,9 +9,6 @@ spec:
   selector:
     matchLabels:
       control-plane: controller-manager
-  namespaceSelector:
-    matchNames:
-    - workload-variant-autoscaler-system
   endpoints:
   - port: http
     scheme: http