Improve InterfaceArchetype annotations

Use a plain class-level @NonNullByDefault, as the only place we have
@nullable is a method argument.

JIRA: YANGTOOLS-1884
Change-Id: I46a36607fbaeb787bc9b5ad50604368b4211094e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Author: rovarga

binding/binding-model/src/main/java/org/opendaylight/yangtools/binding/model/api/InterfaceArchetype.java

@@ -9,7 +9,6 @@
 
 import com.google.common.annotations.Beta;
 import java.util.List;
-import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.eclipse.jdt.annotation.Nullable;
 import org.opendaylight.yangtools.concepts.Mutable;
@@ -21,6 +20,7 @@
  */
 // TODO: a better name perhaps?
 @Beta
+@NonNullByDefault
 public sealed interface InterfaceArchetype extends Archetype permits DataRootArchetype, LegacyArchetype {
     /**
      * Base interface for builders resulting in an {@link InterfaceArchetype}.
@@ -32,7 +32,6 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
         /**
          * {@return a {@link TypeRef} to the type this builder produces}
          */
-        @NonNullByDefault
         TypeRef typeRef();
 
         /**
@@ -41,7 +40,7 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
          * @param annotation the {@link AttachedAnnotation.ToType}, if {@code null} this method does nothing
          * @return this instance
          */
-        @NonNull Builder addAnnotation(AttachedAnnotation.@Nullable ToType annotation);
+        Builder addAnnotation(AttachedAnnotation.@Nullable ToType annotation);
 
         /**
          * Adds a new enclosed {@link Archetype} into definition of Generated Type.
@@ -57,7 +56,6 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
          *
          * @param genType the enclosed {@link Archetype}
          */
-        @NonNullByDefault
         Builder addEnclosedType(Archetype genType);
 
         /**
@@ -66,7 +64,6 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
          * @param genType Type to implement
          * @return <code>true</code> if the addition of type is successful.
          */
-        @NonNullByDefault
         Builder addImplementsType(Type genType);
 
         /**
@@ -80,7 +77,6 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
          * @param value Assigned Value
          * @return <code>new</code> Constant instance.
          */
-        @NonNullByDefault
         Constant addConstant(Type type, String name, Object value);
 
         /**
@@ -92,20 +88,18 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
          * @param name Name of Method
          * @return <code>new</code> instance of Method Signature Builder.
          */
-        @NonNullByDefault
         MethodSignature.Builder addMethod(String name);
 
         /**
          * {@return a new immutable {@link InterfaceArchetype} instance}
          */
-        @NonNull InterfaceArchetype build();
+        InterfaceArchetype build();
     }
 
     /**
      * {@return the list of annotations attached to interface declaration}
      */
     // FIXME: all type annotations should be implied by specialization and this method should not exist
-    @NonNullByDefault
     List<AttachedAnnotation.ToType> annotations();
 
     /**
@@ -115,14 +109,12 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
     //        - only allow GroupingArchetypes here
     //        - have CaseArchetype have a dedicated pointer to its inherited ChoiceArchetype
     //        everything else should be implied by the archetype itself
-    @NonNullByDefault
     List<Type> getImplements();
 
     /**
      * {@return the list of constants the interface defines}
      */
     // FIXME: all constants should be implied by a particular archetype and this method should not exist
-    @NonNullByDefault
     List<Constant> getConstantDefinitions();
 
     /**
@@ -131,6 +123,8 @@ sealed interface Builder extends Mutable permits InterfaceArchetypeBuilder {
     // FIXME: yes, these result in methods being generated, but they are somewhat subtle, as they also imply constants
     //        for builders, etc. Most notably, KeyArchetype is presenting a subset of these defined in its corresponding
     //        LegacyArchetype (or EntryObjectArchetype once that is created)
-    @NonNullByDefault
     List<MethodSignature> getMethodDefinitions();
+
+    @Override
+    String toString();
 }