chore(ci): run integration test on PRs (#80)

Signed-off-by: Niladri Halder <[email protected]>

Author: niladrih

.github/workflows/build.yml

@@ -45,7 +45,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Go 1.16
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2
         with:
           go-version: 1.16.6
 
@@ -65,9 +65,11 @@ jobs:
     runs-on: ubuntu-latest
     needs: ['lint', 'unit-test']
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-
+      - name: Set up Go 1.16
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.6
+          
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs
         run: |
@@ -105,12 +107,12 @@ jobs:
         run: |
           echo "${{ steps.docker_meta.outputs.tags }}"
 
-      - name: Setup QEMU
+      - name: Set up QEMU
         uses: docker/setup-qemu-action@v1
         with:
           platforms: all
 
-      - name: Setup Docker Buildx
+      - name: Set up Docker Buildx
         id: buildx
         uses: docker/setup-buildx-action@v1
         with:
@@ -129,12 +131,16 @@ jobs:
           username: ${{ secrets.QUAY_USERNAME }}
           password: ${{ secrets.QUAY_TOKEN }}
 
-      - name: Build and Push Image
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Build and Push multi-arch Image
         uses: docker/build-push-action@v2
         with:
           context: .
           file: ./buildscripts/provisioner-localpv/provisioner-localpv.Dockerfile
           push: true
+          load: false
           platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
           tags: |
             ${{ steps.docker_meta.outputs.tags }}
@@ -143,6 +149,53 @@ jobs:
             DBUILD_REPO_URL=https://github.com/openebs/dynamic-localpv-provisioner
             DBUILD_SITE_URL=https://openebs.io
 
+  integration-test:
+    runs-on: ubuntu-latest
+    needs: ['lint', 'unit-test']
+    steps:
+      - name: Set up Go 1.16
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.6
+
+      - name: Set up Docker Buildx
+        id: buildx
+        uses: docker/setup-buildx-action@v1
+        with:
+          version: v0.5.1
+
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Build Image
+        uses: docker/build-push-action@v2
+        with:
+          context: .
+          file: ./buildscripts/provisioner-localpv/provisioner-localpv.Dockerfile
+          push: false
+          load: true
+          platforms: linux/amd64
+          tags: |
+            openebs/provisioner-localpv:ci
+
+      - name: Set up Minikube
+        uses: manusa/[email protected]
+        with:
+          minikube version: 'v1.22.0'
+          kubernetes version: 'v1.22.0'
+          driver: none
+
+      - name: Set up Ginkgo
+        run: |
+          go get github.com/onsi/ginkgo/[email protected]
+          ginkgo version || exit 1
+
+      - name: Hostpath Integration Test
+        run: |
+          sed 's/imagePullPolicy: IfNotPresent/imagePullPolicy: Never/g' deploy/kubectl/hostpath-operator.yaml | kubectl apply -f -
+          kubectl apply -f deploy/kubectl/openebs-hostpath-sc.yaml
+          make hostpath-integration-test
+
   localpv-e2e:
     runs-on: ubuntu-latest
     steps:
@@ -168,4 +221,4 @@ jobs:
           load: false
           platforms: linux/amd64
           tags: |
-            ${{ env.IMAGE_ORG }}/localpv-e2e:ci   
+            ${{ env.IMAGE_ORG }}/localpv-e2e:ci

.github/workflows/pull_request.yml

@@ -42,7 +42,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Go 1.16
-        uses: actions/setup-go@v1
+        uses: actions/setup-go@v2
         with:
           go-version: 1.16.6
 
@@ -62,30 +62,83 @@ jobs:
     runs-on: ubuntu-latest
     needs: ['lint', 'unit-test']
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
+      - name: Set up Go 1.16
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.6
 
       - name: Setup QEMU
         uses: docker/setup-qemu-action@v1
         with:
           platforms: all
 
-      - name: Setup Docker Buildx
+      - name: Set up Docker Buildx
         id: buildx
         uses: docker/setup-buildx-action@v1
         with:
           version: v0.5.1
 
-      - name: Build Image
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Build multi-arch Image
         uses: docker/build-push-action@v2
         with:
           context: .
           file: ./buildscripts/provisioner-localpv/provisioner-localpv.Dockerfile
           push: false
+          load: false
           platforms: linux/amd64, linux/arm64, linux/arm/v7, linux/ppc64le
           tags: |
             openebs/provisioner-localpv:ci
 
+  integration-test:
+    runs-on: ubuntu-latest
+    needs: ['lint', 'unit-test']
+    steps:
+      - name: Set up Go 1.16
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.16.6
+
+      - name: Set up Docker Buildx
+        id: buildx
+        uses: docker/setup-buildx-action@v1
+        with:
+          version: v0.5.1
+
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Build Image
+        uses: docker/build-push-action@v2
+        with:
+          context: .
+          file: ./buildscripts/provisioner-localpv/provisioner-localpv.Dockerfile
+          push: false
+          load: true
+          platforms: linux/amd64
+          tags: |
+            openebs/provisioner-localpv:ci
+
+      - name: Set up Minikube
+        uses: manusa/[email protected]
+        with:
+          minikube version: 'v1.22.0'
+          kubernetes version: 'v1.22.0'
+          driver: none
+
+      - name: Set up Ginkgo
+        run: |
+          go get github.com/onsi/ginkgo/[email protected]
+          ginkgo version || exit 1
+
+      - name: Hostpath Integration Test
+        run: |
+          sed 's/imagePullPolicy: IfNotPresent/imagePullPolicy: Never/g' deploy/kubectl/hostpath-operator.yaml | kubectl apply -f -
+          kubectl apply -f deploy/kubectl/openebs-hostpath-sc.yaml
+          make hostpath-integration-test
+
   localpv-e2e:
     runs-on: ubuntu-latest
     steps:
@@ -100,4 +153,4 @@ jobs:
           load: false
           platforms: linux/amd64
           tags: |
-            openebs/localpv-e2e:ci
+            openebs/localpv-e2e:ci

Makefile

@@ -94,6 +94,13 @@ ifeq (${DBUILD_SITE_URL}, )
   export DBUILD_SITE_URL
 endif
 
+# Specify the kubeconfig path to a Kubernetes cluster 
+# to run Hostpath integration tests
+ifeq (${KUBECONFIG}, )
+  KUBECONFIG=${HOME}/.kube/config
+  export KUBECONFIG
+endif
+
 export DBUILD_ARGS=--build-arg DBUILD_DATE=${DBUILD_DATE} --build-arg DBUILD_REPO_URL=${DBUILD_REPO_URL} --build-arg DBUILD_SITE_URL=${DBUILD_SITE_URL} --build-arg BRANCH=${BRANCH} --build-arg RELEASE_TAG=${RELEASE_TAG}
 
 .PHONY: all
@@ -132,6 +139,11 @@ testv: format
 	@echo "--> Running go test verbose" ;
 	@go test -v $(PACKAGES)
 
+# Requires KUBECONFIG env and 'ginkgo' binary
+.PHONY: hostpath-integration-test
+hostpath-integration-test:
+	@cd tests && ginkgo -v --focus="TEST HOSTPATH LOCAL PV"
+
 .PHONY: format
 format:
 	@echo "--> Running go fmt"

deploy/kubectl/provisioner-hostpath.yaml deploy/kubectl/hostpath-operator.yamldeploy/kubectl/provisioner-hostpath.yaml renamed to deploy/kubectl/hostpath-operator.yaml

@@ -24,28 +24,11 @@ rules:
   resources: ["nodes", "nodes/proxy"]
   verbs: ["*"]
 - apiGroups: ["*"]
-  resources: ["namespaces", "services", "pods", "pods/exec", "deployments", "deployments/finalizers", "replicationcontrollers", "replicasets", "events", "endpoints", "configmaps", "secrets", "jobs", "cronjobs"]
+  resources: ["namespaces", "services", "pods", "deployments", "events", "endpoints", "configmaps", "jobs"]
   verbs: ["*"]
-- apiGroups: ["*"]
-  resources: ["statefulsets", "daemonsets"]
-  verbs: ["*"]
-- apiGroups: ["*"]
-  resources: ["resourcequotas", "limitranges"]
-  verbs: ["list", "watch"]
-- apiGroups: ["*"]
-  resources: ["ingresses", "horizontalpodautoscalers", "verticalpodautoscalers", "poddisruptionbudgets", "certificatesigningrequests"]
-  verbs: ["list", "watch"]
 - apiGroups: ["*"]
   resources: ["storageclasses", "persistentvolumeclaims", "persistentvolumes"]
   verbs: ["*"]
-- apiGroups: ["apiextensions.k8s.io"]
-  resources: ["customresourcedefinitions"]
-  verbs: [ "get", "list", "create", "update", "delete", "patch"]
-- apiGroups: ["openebs.io"]
-  resources: [ "*"]
-  verbs: ["*"]
-- nonResourceURLs: ["/metrics"]
-  verbs: ["get"]
 ---
 # Bind the Service Account with the Role Privileges.
 # TODO: Check if default account also needs to be there
@@ -90,7 +73,7 @@ spec:
       containers:
       - name: openebs-provisioner-hostpath
         imagePullPolicy: IfNotPresent
-        image: openebs/provisioner-localpv-ci:dev-120403
+        image: openebs/provisioner-localpv:ci
         env:
         # OPENEBS_IO_K8S_MASTER enables openebs provisioner to connect to K8s
         # based on this address. This is ignored if empty.
@@ -119,13 +102,17 @@ spec:
         - name: OPENEBS_IO_ENABLE_ANALYTICS
           value: "true"
         - name: OPENEBS_IO_INSTALLER_TYPE
-          value: "openebs-operator-lite"
+          value: "openebs-operator-hostpath"
         - name: OPENEBS_IO_HELPER_IMAGE
-          value: "openebs/linux-utils:2.3.0"
+          value: "openebs/linux-utils:ci"
         # LEADER_ELECTION_ENABLED is used to enable/disable leader election. By default
         # leader election is enabled.
         #- name: LEADER_ELECTION_ENABLED
         #  value: "true"
+        # OPENEBS_IO_IMAGE_PULL_SECRETS environment variable is used to pass the image pull secrets
+        # to the helper pod launched by local-pv hostpath provisioner
+        #- name: OPENEBS_IO_IMAGE_PULL_SECRETS
+        #  value: ""
         # Process name used for matching is limited to the 15 characters
         # present in the pgrep output.
         # So fullname can't be used here with pgrep (>15 chars).A regular expression

deploy/kubectl/openebs-lite-sc.yaml deploy/kubectl/openebs-hostpath-sc.yamldeploy/kubectl/openebs-lite-sc.yaml renamed to deploy/kubectl/openebs-hostpath-sc.yaml

@@ -62,14 +62,6 @@ var _ = BeforeSuite(func() {
 	)
 	Expect(provPodCount).To(Equal(1))
 
-	By("waiting for openebs-ndm-operator pod to come into running state")
-	ndmPodCount := ops.GetPodRunningCountEventually(
-		string(artifacts.OpenebsNamespace),
-		string(artifacts.OpenEBSNDMOperatorLabelSelector),
-		1,
-	)
-	Expect(ndmPodCount).To(Equal(1))
-
 	By("building a namespace")
 	namespaceObj, err = ns.NewBuilder().
 		WithGenerateName(namespace).