fix(lints): fix go var name lint errors (#64)

Signed-off-by: prateekpandey14 <[email protected]>

Author: prateekpandey14

.github/workflows/pull_request.yml

@@ -35,12 +35,23 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
+      - name: Set up Go 1.14
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.14.7
+
       - name: Format test
         run: make format
 
       - name: License test
         run: make license-check
 
+      - name: bootstrap
+        run: make bootstrap
+
+      - name: Lint Check
+        run: make golint
+
       - name: Shellcheck
         uses: reviewdog/action-shellcheck@v1
         with:

pkg/lvm/lvm_util.go

@@ -466,22 +466,22 @@ func getVGSize(vgname string) string {
 // the requested volume size and returns the minimum size as a thin pool size
 func getThinPoolSize(vgname, volsize string) string {
 	outStr := getVGSize(vgname)
-	vg_free_size, err := strconv.ParseInt(strings.TrimSpace(string(outStr)), 10, 64)
+	vgFreeSize, err := strconv.ParseInt(strings.TrimSpace(string(outStr)), 10, 64)
 	if err != nil {
 		klog.Errorf("failed to convert vg_size to int, got size,:%v , %v", outStr, err)
 		return ""
 	}
 
-	vol_size, err := strconv.ParseInt(strings.TrimSpace(string(volsize)), 10, 64)
+	volSize, err := strconv.ParseInt(strings.TrimSpace(string(volsize)), 10, 64)
 	if err != nil {
-		klog.Errorf("failed to convert volsize to int, got size,:%v , %v", volsize, err)
+		klog.Errorf("failed to convert volsize to int, got size,:%v , %v", volSize, err)
 		return ""
 	}
 
-	if vg_free_size < vol_size {
+	if vgFreeSize < volSize {
 		// reducing 268435456 bytes (256Mi) from the total byte size to round off
 		// blocks extent
-		return fmt.Sprint(vg_free_size-MinExtentRoundOffSize) + "b"
+		return fmt.Sprint(vgFreeSize-MinExtentRoundOffSize) + "b"
 	}
 	return volsize + "b"
 }

tests/pv/buildlist.go

@@ -24,19 +24,19 @@ import (
 // ListBuilder enables building an instance of
 // PVlist
 type ListBuilder struct {
-	list    *PVList
+	list    *List
 	filters PredicateList
 	errs    []error
 }
 
 // NewListBuilder returns an instance of ListBuilder
 func NewListBuilder() *ListBuilder {
-	return &ListBuilder{list: &PVList{}}
+	return &ListBuilder{list: &List{}}
 }
 
 // ListBuilderForAPIObjects builds the ListBuilder object based on PV api list
 func ListBuilderForAPIObjects(pvs *corev1.PersistentVolumeList) *ListBuilder {
-	b := &ListBuilder{list: &PVList{}}
+	b := &ListBuilder{list: &List{}}
 	if pvs == nil {
 		b.errs = append(b.errs, errors.New("failed to build pv list: missing api list"))
 		return b
@@ -49,7 +49,7 @@ func ListBuilderForAPIObjects(pvs *corev1.PersistentVolumeList) *ListBuilder {
 }
 
 // ListBuilderForObjects builds the ListBuilder object based on PVList
-func ListBuilderForObjects(pvs *PVList) *ListBuilder {
+func ListBuilderForObjects(pvs *List) *ListBuilder {
 	b := &ListBuilder{}
 	if pvs == nil {
 		b.errs = append(b.errs, errors.New("failed to build pv list: missing object list"))
@@ -62,14 +62,14 @@ func ListBuilderForObjects(pvs *PVList) *ListBuilder {
 // List returns the list of pv
 // instances that was built by this
 // builder
-func (b *ListBuilder) List() (*PVList, error) {
+func (b *ListBuilder) List() (*List, error) {
 	if len(b.errs) > 0 {
 		return nil, errors.Errorf("failed to list pv: %+v", b.errs)
 	}
 	if b.filters == nil || len(b.filters) == 0 {
 		return b.list, nil
 	}
-	filteredList := &PVList{}
+	filteredList := &List{}
 	for _, pv := range b.list.items {
 		if b.filters.all(pv) {
 			filteredList.items = append(filteredList.items, pv)

tests/pv/persistentvolume.go

@@ -29,21 +29,21 @@ type PV struct {
 	object *corev1.PersistentVolume
 }
 
-// PVList is a wrapper over persistentvolume api
+// List is a wrapper over persistentvolume api
 // object. It provides build, validations and other common
 // logic to be used by various feature specific callers.
-type PVList struct {
+type List struct {
 	items []*PV
 }
 
 // Len returns the number of items present
 // in the PVList
-func (p *PVList) Len() int {
+func (p *List) Len() int {
 	return len(p.items)
 }
 
 // ToAPIList converts PVList to API PVList
-func (p *PVList) ToAPIList() *corev1.PersistentVolumeList {
+func (p *List) ToAPIList() *corev1.PersistentVolumeList {
 	plist := &corev1.PersistentVolumeList{}
 	for _, pvc := range p.items {
 		plist.Items = append(plist.Items, *pvc.object)