Skip to content

Commit 2297746

Browse files
authored
feat(helm): Disable leader-elections if replicas=1, make logLevel configurable (#146)
* Disable leader-elections if replicas=1, make logLevel configurable * fix(helm): bump chart version
1 parent 0d6acb7 commit 2297746

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

deploy/helm/charts/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v2
22
name: lvm-localpv
33
description: CSI Driver for dynamic provisioning of LVM Persistent Local Volumes.
4-
version: 0.8.2
4+
version: 0.8.3
55
appVersion: 0.8.0
66
icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png
77
home: http://www.openebs.io/

deploy/helm/charts/templates/lvm-controller.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ spec:
4242
- name: {{ .Values.lvmController.resizer.name }}
4343
image: "{{ .Values.lvmController.resizer.image.registry }}{{ .Values.lvmController.resizer.image.repository }}:{{ .Values.lvmController.resizer.image.tag }}"
4444
args:
45-
- "--v=5"
45+
- "--v={{ .Values.lvmController.logLevel }}"
4646
- "--csi-address=$(ADDRESS)"
47+
{{- if gt (int .Values.lvmController.replicas) 1 }}
4748
- "--leader-election"
49+
{{- end }}
4850
env:
4951
- name: ADDRESS
5052
value: /var/lib/csi/sockets/pluginproxy/csi.sock
@@ -59,7 +61,9 @@ spec:
5961
imagePullPolicy: {{ .Values.lvmController.snapshotter.image.pullPolicy }}
6062
args:
6163
- "--csi-address=$(ADDRESS)"
64+
{{- if gt (int .Values.lvmController.replicas) 1 }}
6265
- "--leader-election"
66+
{{- end }}
6367
env:
6468
- name: ADDRESS
6569
value: /var/lib/csi/sockets/pluginproxy/csi.sock
@@ -71,8 +75,10 @@ spec:
7175
- name: {{ .Values.lvmController.snapshotController.name }}
7276
image: "{{ .Values.lvmController.snapshotController.image.registry }}{{ .Values.lvmController.snapshotController.image.repository }}:{{ .Values.lvmController.snapshotController.image.tag }}"
7377
args:
74-
- "--v=5"
78+
- "--v={{ .Values.lvmController.logLevel }}"
79+
{{- if gt (int .Values.lvmController.replicas) 1 }}
7580
- "--leader-election=true"
81+
{{- end }}
7682
imagePullPolicy: {{ .Values.lvmController.snapshotController.image.pullPolicy }}
7783
resources:
7884
{{- toYaml .Values.lvmController.resources | nindent 12 }}
@@ -81,10 +87,12 @@ spec:
8187
imagePullPolicy: {{ .Values.lvmController.provisioner.image.pullPolicy }}
8288
args:
8389
- "--csi-address=$(ADDRESS)"
84-
- "--v=5"
90+
- "--v={{ .Values.lvmController.logLevel }}"
8591
- "--feature-gates=Topology=true"
8692
- "--strict-topology"
93+
{{- if gt (int .Values.lvmController.replicas) 1 }}
8794
- "--leader-election"
95+
{{- end }}
8896
- "--enable-capacity={{ .Values.storageCapacity }}"
8997
- "--extra-create-metadata=true"
9098
- "--default-fstype=ext4"

deploy/helm/charts/templates/lvm-node.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ spec:
3636
image: "{{ .Values.lvmNode.driverRegistrar.image.registry }}{{ .Values.lvmNode.driverRegistrar.image.repository }}:{{ .Values.lvmNode.driverRegistrar.image.tag }}"
3737
imagePullPolicy: {{ .Values.lvmNode.driverRegistrar.image.pullPolicy }}
3838
args:
39-
- "--v=5"
39+
- "--v={{ .Values.lvmNode.logLevel }}"
4040
- "--csi-address=$(ADDRESS)"
4141
- "--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)"
4242
lifecycle:

deploy/helm/charts/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ lvmNode:
5252
priorityClass:
5353
create: true
5454
name: lvm-localpv-csi-node-critical
55+
logLevel: 5
5556

5657

5758
# lvmController contains the configurables for
@@ -60,6 +61,7 @@ lvmController:
6061
componentName: openebs-lvm-controller
6162
replicas: 1
6263
serviceName: openebs-lvm
64+
logLevel: 5
6365
resizer:
6466
name: "csi-resizer"
6567
image:

0 commit comments

Comments
 (0)