Skip to content

Commit 87590b7

Browse files
authored
Multi tag fix (#578)
* fix: build issue with multiple tag on HEAD + missing tag in kubectl binary Signed-off-by: Prateek Chandra <[email protected]> * fix: following the fix as in dataplane just to be in sync Signed-off-by: Prateek Chandra <[email protected]> --------- Signed-off-by: Prateek Chandra <[email protected]>
1 parent 9a45458 commit 87590b7

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.github/workflows/release_artifacts.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,15 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/[email protected]
12+
with:
13+
submodules: recursive
14+
fetch-depth: 0
15+
- run: |
16+
# BUG: HEAD tag is fetched as lightweight instead of annotated
17+
# https://github.com/actions/checkout/issues/290
18+
if [ "${{ github.ref_type }}" == "tag" ]; then
19+
git fetch -f origin ${{ github.ref }}:${{ github.ref }}
20+
fi
1221
- uses: cachix/install-nix-action@v15
1322
with:
1423
nix_path: nixpkgs=channel:nixos

scripts/release.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ dockerhub_tag_exists() {
1616

1717
# Get the tag at the HEAD
1818
get_tag() {
19-
vers=`git tag --points-at HEAD`
19+
vers=`git describe --exact-match 2>/dev/null || echo ""`
2020
echo -n $vers
2121
}
2222
get_hash() {

0 commit comments

Comments
 (0)