ci(stability): merge the develop branch

Author: datacore-bolt-ci

.github/workflows/helm-chart.yml

@@ -48,6 +48,12 @@ jobs:
         run: nix-shell ./scripts/helm/shell.nix --run "echo"
       - name: Generate image list
         run: nix-shell ./scripts/helm/shell.nix --run "./scripts/helm/images.sh generate --dependency-update --exit-code"
+      - name: Login to Docker Hub
+        uses: docker/login-action@v3
+        with:
+          registry: docker.io
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
       - name: BootStrap k8s cluster
         if: github.event_name != 'pull_request'
         run: nix-shell ./scripts/k8s/shell.nix --run "./scripts/k8s/deployer.sh start --label"

.github/workflows/k8s-ci.yml

@@ -36,6 +36,20 @@ jobs:
         run: nix-shell ./scripts/helm/shell.nix --run "echo"
       - name: Pre-populate pytest nix-shell
         run: nix-shell ./scripts/python/shell.nix --run "echo"
+      - name: Login to Docker Hub
+        if: ${{ !inputs.helm-pins }}
+        uses: docker/login-action@v3
+        with:
+          registry: docker.io
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+      - name: Login to Helm Pins Registry
+        if: ${{ inputs.helm-pins }}
+        uses: docker/login-action@v3
+        with:
+          registry: ${{ inputs.registry }}
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
       - name: BootStrap k8s cluster
         run: |
           sudo debconf-communicate <<< "set man-db/auto-update false" || true
@@ -47,13 +61,6 @@ jobs:
       - name: Load images to kind cluster
         if: ${{ !inputs.helm-pins }}
         run: nix-shell ./scripts/python/shell.nix --run "./scripts/python/upgrade-test-helper.sh --load"
-      - name: Login to Helm Pins Registry
-        if: ${{ inputs.helm-pins }}
-        uses: docker/login-action@v3
-        with:
-          registry: ${{ inputs.registry }}
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
       - name: Create Pinned Helm Chart
         id: pin
         if: ${{ inputs.helm-pins }}

.github/workflows/nightly-ci.yml

@@ -5,6 +5,7 @@ on:
 jobs:
   ci:
     uses: ./.github/workflows/pr-ci.yml
+    secrets: inherit
   helm-pins:
     uses: ./.github/workflows/helm-pins.yml
     secrets: inherit

.github/workflows/pr-ci.yml

@@ -11,12 +11,14 @@ jobs:
     uses: ./.github/workflows/lint.yml
   helm-ci:
     uses: ./.github/workflows/helm-chart.yml
+    secrets: inherit
   int-ci:
     uses: ./.github/workflows/unit-int.yml
   image-ci:
     uses: ./.github/workflows/image-pr.yml
   k8s-ci:
     uses: ./.github/workflows/k8s-ci.yml
+    secrets: inherit
   bors-ci:
     if: ${{ success() }}
     needs:

dependencies/control-plane

@@ -19,6 +19,7 @@ LABEL=
 CLEANUP="false"
 IPFAM="ipv4"
 SUDO=${SUDO:-"sudo"}
+USE_DOCKER_CFG="true"
 
 help() {
   cat <<EOF
@@ -35,6 +36,7 @@ Options:
   --label                           Label worker nodes with the io-engine selector.
   --cleanup                         Prior to starting, stops the running instance of the deployer.
   --ip-family     <str>             KIND has support for IPv4, IPv6 and dual-stack clusters, with the default being ipv4.
+  --no-login                        Don't use the docker config json file.
 
 Command:
   start                             Start the k8s cluster.
@@ -120,6 +122,9 @@ while [ "$#" -gt 0 ]; do
               ;;
           esac
           ;;
+        --no-login)
+          USE_DOCKER_CFG="false"
+          shift;;
         --dry-run)
           if [ -z "$DRY_RUN" ]; then
             DRY_RUN="--dry-run"
@@ -192,6 +197,13 @@ for node_index in $(seq 1 "$WORKERS"); do
       containerPath: /var/local/mayastor
       propagation: HostToContainer
 EOF
+  DOCKER_CONFIG="$HOME/.docker/config.json"
+  if [ "$USE_DOCKER_CFG" = "true" ] && [ -f "$DOCKER_CONFIG" ]; then
+    cat <<EOF >> "$TMP_KIND_CONFIG"
+    - hostPath: $DOCKER_CONFIG
+      containerPath: /var/lib/kubelet/config.json
+EOF
+  fi
   if [ -n "$LABEL" ]; then
     cat <<EOF >> "$TMP_KIND_CONFIG"
   labels: