chore(bors): merge pull request #728

728: chore: tunable for allowing non-persistent devpath for disks r=dsharma-dc a=dsharma-dc



Co-authored-by: Diwakar Sharma <[email protected]>

Author: mayastor-bors

chart/README.md

@@ -66,6 +66,7 @@ This removes all the Kubernetes components associated with the chart and deletes
 
 | Key | Description | Default |
 |:----|:------------|:--------|
+| agents.​core.​allowNonPersistentDevlink | Allow using non-persistent kernel devpaths for pool disks. Enabling this will let users to use the kernel devpaths e.g /dev/sda, for diskpools. However, this comes with associated risks if the devpaths get swapped among disks, resulting in total data loss especially if encryption is being used. | `false` |
 | agents.​core.​capacity.​thin.​poolCommitment | The allowed pool commitment limit when dealing with thin provisioned volumes. Example: If the commitment is 250 and the pool is 10GiB we can overcommit the pool up to 25GiB (create 2 10GiB and 1 5GiB volume) but no further. | `"250%"` |
 | agents.​core.​capacity.​thin.​snapshotCommitment | When creating snapshots for an existing volume, each replica pool must have at least this much free space percentage of the volume size. Example: if this value is 40, the pool has 40GiB free, then the max volume size allowed to be snapped on the pool is 100GiB. | `"40%"` |
 | agents.​core.​capacity.​thin.​volumeCommitment | When creating replicas for an existing volume, each replica pool must have at least this much free space percentage of the volume size. Example: if this value is 40, the pool has 40GiB free, then the max volume size allowed to be created on the pool is 100GiB. | `"40%"` |

chart/templates/mayastor/agents/core/agent-core-deployment.yaml

@@ -74,6 +74,8 @@ spec:
             - "--no-volume-health"{{ end }}
             {{- if eq .Values.agents.core.encryptedPoolsSoftScheduling true }}
             - "--encrypted-pools-soft-scheduling"{{- end }}
+            {{- if eq .Values.agents.core.allowNonPersistentDevlink true}}
+            - "--allow-non-persistent-devlink"{{- end }}
           ports:
             - containerPort: 50051
           env:

chart/values.yaml

@@ -209,6 +209,10 @@ agents:
     # If a volume wasn't provisioned with a encryption storageclass, we try to place the replicas of such volume on best-effort basis onto encrypted pools, if this global is set.
     # This is effective subject to volume spec already modified via plugin to request encryption.
     encryptedPoolsSoftScheduling: false
+    # -- Allow using non-persistent kernel devpaths for pool disks.
+    # Enabling this will let users to use the kernel devpaths e.g /dev/sda, for diskpools. However, this comes with associated risks if the devpaths
+    # get swapped among disks, resulting in total data loss especially if encryption is being used.
+    allowNonPersistentDevlink: false
   ha:
     enabled: true
     node: