Skip to content

Commit a4de51d

Browse files
test: debug
Signed-off-by: Tiago Castro <[email protected]>
1 parent d2c7a44 commit a4de51d

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

.github/workflows/bdd.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
name: BDD CI
22
on:
33
workflow_call:
4+
# push:
5+
# branches:
6+
# - gha-runners
7+
48

59
env:
610
CARGO_TERM_COLOR: always
@@ -61,14 +65,15 @@ jobs:
6165
done
6266
# for the coredump check
6367
sudo apt-get install gdb
68+
echo "Multipath: $(cat /sys/module/nvme_core/parameters/multipath)"
6469
6570
- name: Setup VENV
6671
run: nix-shell --run "./test/python/setup.sh"
6772

6873
- name: Run BDD Tests
6974
run: |
7075
echo "TEST_START_DATE=$(date +"%Y-%m-%d %H:%M:%S")" >> $GITHUB_ENV
71-
nix-shell --run "./scripts/pytest-tests.sh"
76+
nix-shell --pure --run "./scripts/pytest-tests.sh"
7277
7378
- name: Pytest BDD Report
7479
if: always()

.github/workflows/unit-int.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Integration CI
22
on:
33
workflow_call:
4+
push:
5+
branches:
6+
- gha-runners
47

58
env:
69
CARGO_TERM_COLOR: always
@@ -9,6 +12,8 @@ env:
912

1013
jobs:
1114
int-tests:
15+
#runs-on: oracle-vm-16cpu-64gb-x86-64
16+
#runs-on: ubuntu-latest-16-cores
1217
runs-on: oracle-vm-16cpu-64gb-x86-64
1318
permissions:
1419
contents: read
@@ -62,10 +67,7 @@ jobs:
6267
sudo modprobe $module
6368
done
6469
sudo apt-get install gdb
65-
# Add debug info
66-
lsblk
67-
df -h
68-
mount
70+
echo "Multipath: $(cat /sys/module/nvme_core/parameters/multipath)"
6971
7072
- name: Run Rust Tests
7173
run: |
@@ -115,7 +117,7 @@ jobs:
115117
if: always()
116118
run: nix-shell --run "./scripts/clean-cargo-tests.sh"
117119
# debugging
118-
# - name: Setup tmate session
119-
# if: ${{ failure() }}
120-
# timeout-minutes: 240
121-
# uses: mxschmitt/action-tmate@v3
120+
- name: Setup tmate session
121+
if: ${{ failure() }}
122+
timeout-minutes: 240
123+
uses: mxschmitt/action-tmate@v3

test/python/common/nvme.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def nvme_find_ctrl(uri):
121121

122122
# Finds correct Device
123123
devs = list(filter(lambda d: nqn in d.get("SubsystemNQN"), discover.get("Devices")))
124-
assert len(devs) is 1, "Multiple devices with the same subnqn"
124+
assert len(devs) == 1, "Multiple devices with the same subnqn"
125125

126126
# Find correct Controller
127127
ctrls = list(
@@ -130,7 +130,7 @@ def nvme_find_ctrl(uri):
130130
devs[0].get("Controllers"),
131131
)
132132
)
133-
assert len(ctrls) is 1, "Multiple controllers with the same address"
133+
assert len(ctrls) == 1, "Multiple controllers with the same address"
134134

135135
return ctrls[0].get("Controller")
136136

0 commit comments

Comments
 (0)