Skip to content

Commit 0aa7cb3

Browse files
Merge pull request #122 from openebs/ver_60
cherry pick #121 removing unused jsonnet modules
2 parents eff5254 + 1a97413 commit 0aa7cb3

28 files changed

+470
-739
lines changed

.github/workflows/jsonnet-lint.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ jobs:
2121
with:
2222
fetch-depth: 0
2323

24-
- name: Jsonnet formatter
24+
- name: Jsonnet formatter and linter
2525
run: |
26-
cd jsonnet && make --always-make fmt
27-
28-
- name: Jsonnet linter
29-
run: |
30-
cd jsonnet && make --always-make lint
26+
cd jsonnet && make --always-make all
27+

deploy/charts/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ keywords:
2222
# This is the chart version. This version number should be incremented each time you make changes
2323
# to the chart and its templates, including the app version.
2424
# Versions are expected to follow Semantic Versioning (https://semver.org/)
25-
version: 4.0.0
25+
version: 4.0.1
2626

2727
# This is the version number of the application being deployed. This version number should be
2828
# incremented each time you make changes to the application. Versions are not expected to
2929
# follow Semantic Versioning. They should reflect the version the application is using.
30-
appVersion: 4.0.0
30+
appVersion: 4.0.1
3131

3232
dependencies:
3333
- name: kube-prometheus-stack

deploy/charts/README.md

Lines changed: 115 additions & 133 deletions
Large diffs are not rendered by default.

deploy/charts/templates/_helpers.tpl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,5 +80,8 @@ Usage:
8080
{{- range $subchart }}
8181
{{- $values = index $values . }}
8282
{{- end }}
83-
{{- include $template (dict "Chart" (dict "Name" (last $subchart)) "Values" $values "Release" $dot.Release "Capabilities" $dot.Capabilities) }}
83+
{{- if $values.enabled }}
84+
{{- include $template (dict "Chart" (dict "Name" (last $subchart)) "Values" $values "Release" $dot.Release "Capabilities" $dot.Capabilities) }}
8485
{{- end }}
86+
{{- end }}
87+

deploy/charts/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ kube-prometheus-stack:
3939

4040
## Additional container arguments
4141
extraArgs:
42-
- --collector.filesystem.ignored-mount-points=^/(dev|proc|sys|var/lib/docker/.+)($|/)
43-
- --collector.filesystem.ignored-fs-types=^(tmpfs|autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$
44-
- --collector.diskstats.ignored-devices=^(ram|loop|fd|(h|s|v|xv)d[a-z]+|nvme\\d+n\\d+p)\\d+$
42+
- --collector.filesystem.mount-points-exclude=^/(dev|proc|sys|var/lib/docker/.+)($|/)
43+
- --collector.filesystem.fs-types-exclude=^(tmpfs|autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$
44+
- --collector.diskstats.device-exclude=^(ram|loop|fd|sr|(h|s|v|xv)d[a-z]+|nvme\d+n\d+p|nvme\d+c\d+n)\d+$
4545

4646
prometheus:
4747
service:

jsonnet/Makefile

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,45 +2,30 @@ SHELL=/usr/bin/env bash -o pipefail
22

33
BIN_DIR?=$(shell pwd)/tmp/bin
44

5-
EMBEDMD_BIN=$(BIN_DIR)/embedmd
65
JB_BIN=$(BIN_DIR)/jb
7-
GOJSONTOYAML_BIN=$(BIN_DIR)/gojsontoyaml
86
JSONNET_BIN=$(BIN_DIR)/jsonnet
97
JSONNETLINT_BIN=$(BIN_DIR)/jsonnet-lint
108
JSONNETFMT_BIN=$(BIN_DIR)/jsonnetfmt
11-
KUBECONFORM_BIN=$(BIN_DIR)/kubeconform
12-
TOOLING=$(EMBEDMD_BIN) $(JB_BIN) $(GOJSONTOYAML_BIN) $(JSONNET_BIN) $(JSONNETLINT_BIN) $(JSONNETFMT_BIN) $(KUBECONFORM_BIN)
9+
TOOLING=$(JB_BIN) $(JSONNET_BIN) $(JSONNETLINT_BIN) $(JSONNETFMT_BIN)
1310

1411
JSONNETFMT_ARGS=-n 2 --max-blank-lines 2 --string-style s --comment-style s
1512

16-
KUBE_VERSION?="1.20.0"
17-
18-
all: lint fmt generate
13+
all: lint fmt
1914

2015
.PHONY: clean
2116
clean:
2217
# Remove all files and directories ignored by git.
2318
git clean -Xfd .
2419

25-
.PHONY: generate
26-
generate: manifests
27-
28-
manifests: main.jsonnet $(GOJSONTOYAML_BIN) vendor buildscripts/build.sh
29-
./buildscripts/build.sh $<
30-
31-
vendor: $(JB_BIN) jsonnetfile.json jsonnetfile.lock.json
32-
rm -rf vendor
33-
$(JB_BIN) install
34-
3520
.PHONY: fmt
3621
fmt: $(JSONNETFMT_BIN)
37-
find . -name 'vendor' -prune -o -name '*.libsonnet' -print -o -name '*.jsonnet' -print | \
22+
find . -name '*.libsonnet' -print -o -name '*.jsonnet' -print | \
3823
xargs -n 1 -- $(JSONNETFMT_BIN) $(JSONNETFMT_ARGS) -i
3924

4025
.PHONY: lint
41-
lint: $(JSONNETLINT_BIN) vendor
42-
find . -name 'vendor' -prune -o -name '*.libsonnet' -print -o -name '*.jsonnet' -print | \
43-
xargs -n 1 -- $(JSONNETLINT_BIN) -J vendor
26+
lint: $(JSONNETLINT_BIN)
27+
find . -name '*.libsonnet' -print -o -name '*.jsonnet' -print | \
28+
xargs -n 1 -- $(JSONNETLINT_BIN)
4429

4530

4631
$(BIN_DIR):

jsonnet/README.md

Lines changed: 0 additions & 35 deletions
This file was deleted.

jsonnet/addons/dashboard-cm.libsonnet

Lines changed: 0 additions & 20 deletions
This file was deleted.

jsonnet/addons/podMonitors.libsonnet

Lines changed: 0 additions & 12 deletions
This file was deleted.

jsonnet/addons/prometheusRules.libsonnet

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)