Skip to content

Commit ac1fc45

Browse files
authored
Cleanup legacy dashboards (#113)
* cleanup legacy dashboards Signed-off-by: w3aman <[email protected]> * ci: bump ci workflows Signed-off-by: w3aman <[email protected]> * add persistence in prometheus and grafana Signed-off-by: w3aman <[email protected]> * add openebs provisioner dependency to helm chart Signed-off-by: w3aman <[email protected]> * chore: add chart.lock to gitignore Signed-off-by: w3aman <[email protected]> * fix: remove dependency lock on helm chart Signed-off-by: w3aman <[email protected]> * feat(chart): bump localpv-provisioner version to 4.1.0 Signed-off-by: w3aman <[email protected]> --------- Signed-off-by: w3aman <[email protected]>
1 parent 3da513a commit ac1fc45

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+167
-23140
lines changed

.github/workflows/chart-lint-test.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,36 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- name: Checkout
20-
uses: actions/checkout@v2
20+
uses: actions/checkout@v4
2121
with:
2222
fetch-depth: 0
2323

2424
- name: Set up Helm
25-
uses: azure/setup-helm@v1
25+
uses: azure/setup-helm@v4
2626
with:
27-
version: v3.5.0
27+
version: v3.14.3
2828

29-
- uses: actions/setup-python@v2
29+
- uses: actions/setup-python@v5
3030
with:
31-
python-version: 3.7
31+
python-version: '3.10'
32+
check-latest: true
3233

3334
- name: Set up chart-testing
34-
uses: helm/chart-testing-action@v2.0.1
35+
uses: helm/chart-testing-action@v2.6.1
3536

3637
- name: Run chart-testing (list-changed)
3738
id: list-changed
3839
run: |
3940
changed=$(ct list-changed --config ct.yml)
4041
if [[ -n "$changed" ]]; then
41-
echo "::set-output name=changed::true"
42+
echo "changed=true" >> $GITHUB_OUTPUT
4243
fi
4344
4445
- name: Run chart-testing (lint)
4546
run: ct lint --config ct.yml
4647

4748
- name: Create kind cluster
48-
uses: helm/kind-action@v1.2.0
49+
uses: helm/kind-action@v1.9.0
4950
if: steps.list-changed.outputs.changed == 'true'
5051

5152
- name: Run chart-testing (install)

.github/workflows/jsonnet-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- name: Checkout
20-
uses: actions/checkout@v2
20+
uses: actions/checkout@v4
2121
with:
2222
fetch-depth: 0
2323

.github/workflows/release-charts.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- name: Checkout
15-
uses: actions/checkout@v2
15+
uses: actions/checkout@v4
1616
with:
1717
fetch-depth: 0
1818

@@ -22,17 +22,18 @@ jobs:
2222
git config user.email "[email protected]"
2323
2424
- name: Install Helm
25-
uses: azure/setup-helm@v1
25+
uses: azure/setup-helm@v4
2626
with:
27-
version: v3.5.0
27+
version: v3.14.3
2828

2929
- name: Add dependency chart repos
3030
run: |
3131
helm repo add kube-prometheus-stack https://prometheus-community.github.io/helm-charts
3232
helm repo add node-problem-detector https://charts.deliveryhero.io/
33+
helm repo add localpv-provisioner https://openebs.github.io/dynamic-localpv-provisioner
3334
3435
- name: Run chart-releaser
35-
uses: helm/chart-releaser-action@v1.2.1
36+
uses: helm/chart-releaser-action@v1.6.0
3637
env:
3738
CR_TOKEN: "${{ secrets.CR_TOKEN }}"
3839
with:

.gitignore

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
# Chart dependencies
22
/deploy/charts/charts
3-
.idea
3+
/deploy/charts/Chart.lock
4+
5+
# ide
6+
**/.idea
7+
48
jsonnet/vendor/
59
jsonnet/tmp/
610
jsonnet/buildscripts/vendor/
7-
jsonnet/manifests
11+
jsonnet/manifests

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ A set of Grafana dashboards and Prometheus alerts for OpenEBS that can be instal
66

77
## Status
88

9-
**Beta**. This repository currently supports dashboards and alerts for `cStor`, `Jiva`, `LVM LocalPV` OpenEBS storage engines.
9+
**Beta**. This repository currently supports dashboards and alerts for `Mayastor`, `LocalPV LVM`, `LocalPV ZFS` OpenEBS storage engines.
1010
This project is under active development and seeking [contributions from the community](#contributing).
1111

1212

@@ -17,15 +17,15 @@ This project is under active development and seeking [contributions from the com
1717
Setup the monitoring helm repository.
1818

1919
```console
20-
helm repo add openebs-monitoring https://openebs.github.io/monitoring/
20+
helm repo add monitoring https://openebs.github.io/monitoring/
2121
helm repo update
2222
```
2323

24-
You can then run `helm search repo openebs-monitoring` to see the charts.
24+
You can then run `helm search repo monitoring` to see the charts.
2525

2626
Install the helm chart.
2727
```
28-
helm install openebs-monitoring openebs-monitoring/openebs-monitoring --namespace openebs --create-namespace
28+
helm install monitoring monitoring/monitoring --namespace openebs --create-namespace
2929
```
3030

3131
The detailed chart documentation is available in [charts directory](/deploy/charts/README.md).

contribute/design.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# openEBS Monitoring
22

3-
![openebs-monitoring](images/openebs-monitoring.png)
3+
![monitoring](images/monitoring.png)
44

55
OpenEBS monitoring written in jsonnet has two components:
66
1. [**kube-prometheus stack**](https://github.com/prometheus-operator/kube-prometheus/tree/main/jsonnet/kube-prometheus)
@@ -14,7 +14,7 @@ OpenEBS monitoring written in jsonnet has two components:
1414

1515
```
1616
jsonnet
17-
├── addons # openebs-monitoring addon
17+
├── addons # monitoring addon
1818
│ ├── podMonitors.libsonnet # podMonitor to be created for different cas types
1919
│ ├── prometheusRules.libsonnet # create prometheusRule object which includes alert rules defined in openebs-mixin
2020
│ └── serviceMonitors.libsonnet # serviceMonitor to be created for different cas types
@@ -25,7 +25,7 @@ OpenEBS monitoring written in jsonnet has two components:
2525
├── jsonnetfile.lock.json # all dependencies with exact version
2626
|
2727
├── lib # contains code that is used in different places
28-
│ └── utils.libsonnet # code which is used to create openebs-monitoring addons
28+
│ └── utils.libsonnet # code which is used to create monitoring addons
2929
|
3030
├── main.jsonnet # entrypoint of code(openEBS Monitoring)
3131
├── Makefile

contribute/release.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@ To generate dashboards and alert rules for monitoring helm chart and release a n
77

88
2. Update the dashboards and rules folder in [build.sh](../jsonnet/openebs-mixin/build.sh). The auto generated json files will be inside this folder.
99

10-
For example: If you add dashboards and alert rules for mayastor in openebs-mixin, then add mayastor as a folder name in build.sh file.
10+
For example: If you add dashboards and alert rules for Mayastor in openebs-mixin, then add mayastor as a folder name in build.sh file.
1111
```
1212
generateDashboards(){
1313
. . .
14-
dashboardsFolder=(cStor jiva localPV npd lvmLocalPV ndm mayastor)
14+
dashboardsFolder=(npd lvmLocalPV zfsLocalPV mayastor)
1515
. . .
1616
}
1717
1818
generateRules(){
1919
. . .
20-
rulesFolder=(cStor jiva volume npd lvmLocalPV mayastor)
20+
rulesFolder=(npd lvmLocalPV zfsLocalPV mayastor)
2121
. . .
2222
}
2323
```

ct.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@ chart-dirs:
66
chart-repos:
77
- kube-prometheus-stack=https://prometheus-community.github.io/helm-charts
88
- node-problem-detector=https://charts.deliveryhero.io/
9+
- localpv-provisioner=https://openebs.github.io/dynamic-localpv-provisioner
910
helm-extra-args: --timeout=500s
11+
validate-maintainers: false

deploy/charts/Chart.lock

Lines changed: 0 additions & 9 deletions
This file was deleted.

deploy/charts/Chart.yaml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
apiVersion: v2
2-
name: openebs-monitoring
2+
name: monitoring
33
description: A Helm chart for monitoring OpenEBS
44

55
# A chart can be either an 'application' or a 'library' chart.
@@ -12,18 +12,6 @@ description: A Helm chart for monitoring OpenEBS
1212
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
1313
type: application
1414

15-
maintainers:
16-
- name: kiranmova
17-
18-
- name: avishnu
19-
20-
- name: Ab-hishek
21-
22-
- name: rajaSahil
23-
24-
- name: Sanjay1611
25-
26-
2715
sources:
2816
- https://github.com/openebs/monitoring
2917

@@ -34,12 +22,12 @@ keywords:
3422
# This is the chart version. This version number should be incremented each time you make changes
3523
# to the chart and its templates, including the app version.
3624
# Versions are expected to follow Semantic Versioning (https://semver.org/)
37-
version: 0.4.13
25+
version: 3.0.0
3826

3927
# This is the version number of the application being deployed. This version number should be
4028
# incremented each time you make changes to the application. Versions are not expected to
4129
# follow Semantic Versioning. They should reflect the version the application is using.
42-
appVersion: 2.12.0
30+
appVersion: 3.0.0
4331

4432
dependencies:
4533
- name: kube-prometheus-stack
@@ -50,3 +38,7 @@ dependencies:
5038
version: "2.0.*"
5139
repository: https://charts.deliveryhero.io/
5240
condition: node-problem-detector.install
41+
- name: localpv-provisioner
42+
version: 4.1.0
43+
repository: https://openebs.github.io/dynamic-localpv-provisioner
44+
condition: localpv-provisioner.enabled

0 commit comments

Comments
 (0)