✏️ Node Plugin config validation

Signed-off-by: Muhammed Hussain Karimi <[email protected]>

Author: mhkarimi1383

.github/workflows/k8s.yml

@@ -103,10 +103,10 @@ jobs:
         with:
           name: smoke-k8s-dump
           path: dump
-      # - name: Setup tmate session
-      #   if: ${{ failure() }}
-      #   timeout-minutes: 120
-      #   uses: mxschmitt/action-tmate@v3
+      - name: Setup tmate session
+        if: ${{ failure() }}
+        timeout-minutes: 120
+        uses: mxschmitt/action-tmate@v3
 
   release-check:
     if: ${{ inputs.release-check }}

rawfile/config/model.py

@@ -123,7 +123,7 @@ def parse_dict(cls, v):
     def validate_node_plugin(
         self,
     ):
-        if self.plugin_type != "node":
+        if self.plugin_type == "node":
             if not self.internal_ip:
                 raise ValueError(
                     "Internal Communication IP/PORT is required on node plugin"

rawfile/utils/volume_manager.py

@@ -46,8 +46,8 @@ def create_volume(
         self,
         volume_id: str,
         size: int,
-        thin_provision: bool,
         storage_pool: str,
+        thin_provision: bool,
         freezefs: bool | None = None,
         copy_on_write: bool | None = None,
         source_type: VolumeSource | None = None,