🚧 Adding storage pool support #254
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 013931c. 🟢 All jobs passed!But CI Insights is watching 👀 |
Member
Author
|
Can you review the structure of the configuration? |
| default=None, | ||
| description="Overrides total capacity of storage pool", | ||
| ) | ||
| default_fs: FileSystemName = Field( |
Member
There was a problem hiding this comment.
I see this more as a "frontend" rather than a "backend storage-pool" configuration?
Member
Author
There was a problem hiding this comment.
This will be used to make how users are configuring storage pools
mhkarimi1383
force-pushed
the
storage-pool
branch
from
fcf7f6b to
bbe03f4
Compare
Member
Author
|
@mergify rebase |
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
Contributor
✅ Branch has been successfully rebased |
mhkarimi1383
force-pushed
the
storage-pool
branch
6 times, most recently
from
88d8b18 to
a6000ef
Compare
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
mhkarimi1383
force-pushed
the
storage-pool
branch
from
a6000ef to
03d3252
Compare
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
mhkarimi1383
force-pushed
the
storage-pool
branch
2 times, most recently
from
c0722a1 to
6f002de
Compare
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
mhkarimi1383
force-pushed
the
storage-pool
branch
from
6f002de to
f2d1f95
Compare
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
Signed-off-by: Muhammed Hussain Karimi <[email protected]>
mhkarimi1383
force-pushed
the
storage-pool
branch
from
af3e911 to
013931c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #234