nit: Fixed review comment from Tiago

Address the review comment from Tiago to remove the race window of poller being unregistred

Signed-off-by: Susobhan Dey <susobhan.dey@gmail.com>

Author: susobhandey

lib/nvmf/ctrlr.c

@@ -4859,7 +4859,7 @@ nvmf_check_subsystem_active(struct spdk_nvmf_request *req)
 	struct spdk_nvmf_subsystem_poll_group *sgroup = NULL;
 	struct spdk_nvmf_subsystem_pg_ns_info *ns_info;
 	uint32_t nsid;
-	struct spdk_nvmf_subsystem *subsystem = NULL;
+	struct spdk_nvmf_subsystem *subsystem;
 
 	if (spdk_likely(qpair->ctrlr)) {
 		sgroup = &qpair->group->sgroups[qpair->ctrlr->subsys->id];

lib/nvmf/subsystem.c

@@ -879,11 +879,6 @@ spdk_nvmf_subsystem_resume_ext(struct spdk_nvmf_subsystem *subsystem,
 			   spdk_nvmf_subsystem_state_change_done cb_fn,
 			   void *cb_arg)
 {
-	subsystem->pause_flags = 0;
-	if (subsystem->pause_timer) {
-		spdk_poller_unregister(&subsystem->pause_timer);
-		subsystem->pause_timer = NULL;
-	}
 	return spdk_nvmf_subsystem_resume(subsystem, cb_fn, cb_arg);
 }
 
@@ -892,6 +887,11 @@ spdk_nvmf_subsystem_resume(struct spdk_nvmf_subsystem *subsystem,
 			   spdk_nvmf_subsystem_state_change_done cb_fn,
 			   void *cb_arg)
 {
+	subsystem->pause_flags = 0;
+	if (subsystem->pause_timer) {
+		spdk_poller_unregister(&subsystem->pause_timer);
+		subsystem->pause_timer = NULL;
+	}
 	return nvmf_subsystem_state_change(subsystem, 0, SPDK_NVMF_SUBSYSTEM_ACTIVE, cb_fn, cb_arg);
 }