refactor: replace external_key initialization with build_external_key method

Author: BryanttV

cms/djangoapps/contentstore/tests/test_course_listing.py

@@ -724,7 +724,7 @@ def test_course_listing_with_org_scope(self):
         the AuthZ course authoring toggle is enabled.
         """
         _, _, authz_courses, legacy_courses = self._create_courses()
-        org_scope = OrgCourseOverviewGlobData(external_key='course-v1:Org1+*')
+        org_scope = OrgCourseOverviewGlobData.build_external_key("Org1")
         assign_role_to_user_in_scope(
             self.authorized_user.username,
             COURSE_STAFF.external_key,
@@ -757,7 +757,7 @@ def test_course_listing_with_org_scope_with_toggle(self):
         authz_keys, _, _, _ = self._create_courses()
         # enable only the first and third course keys
         enabled_keys = {str(authz_keys[0]), str(authz_keys[2])}
-        org_scope = OrgCourseOverviewGlobData(external_key='course-v1:Org1+*')
+        org_scope = OrgCourseOverviewGlobData.build_external_key("Org1")
         assign_role_to_user_in_scope(
             self.authorized_user.username,
             COURSE_STAFF.external_key,
@@ -784,7 +784,7 @@ def test_course_listing_with_org_scope_without_courses(self):
         courses, `get_courses_accessible_to_user` should return an empty
         list.
         """
-        org_scope = OrgCourseOverviewGlobData(external_key='course-v1:Org2+*')
+        org_scope = OrgCourseOverviewGlobData.build_external_key("Org2")
         assign_role_to_user_in_scope(
             self.authorized_user.username,
             COURSE_STAFF.external_key,
@@ -806,8 +806,8 @@ def test_course_listing_with_org_scope_fetched_once(self):
         """
         Verify that course overviews are fetched once with all authorized orgs.
         """
-        org_scope1 = OrgCourseOverviewGlobData(external_key='course-v1:Org1+*')
-        org_scope2 = OrgCourseOverviewGlobData(external_key='course-v1:Org2+*')
+        org_scope1 = OrgCourseOverviewGlobData.build_external_key("Org1")
+        org_scope2 = OrgCourseOverviewGlobData.build_external_key("Org2")
         assign_role_to_user_in_scope(
             self.authorized_user.username,
             COURSE_STAFF.external_key,

common/djangoapps/student/tests/test_roles.py

@@ -310,7 +310,7 @@ def test_get_authz_compat_course_access_roles_for_user_org_scope(self):
         """
         Org-wide AuthZ assignments should map to legacy org-level course access roles.
         """
-        org_scope = OrgCourseOverviewGlobData(external_key="course-v1:OpenedX+*")
+        org_scope = OrgCourseOverviewGlobData.build_external_key("OpenedX")
         assignment = RoleAssignmentData(
             subject=UserData(external_key=self.student.username),
             roles=[RoleData(external_key=COURSE_ADMIN.external_key)],
@@ -338,7 +338,7 @@ def test_org_scope_authz_role_grants_instructor_dashboard_permissions(self):
         """
         # pylint: disable=protected-access
         course_key = CourseKey.from_string("course-v1:OpenedX+DemoX+DemoCourse")
-        org_scope = OrgCourseOverviewGlobData(external_key="course-v1:OpenedX+*")
+        org_scope = OrgCourseOverviewGlobData.build_external_key("OpenedX")
         assignment = RoleAssignmentData(
             subject=UserData(external_key=self.student.username),
             roles=[RoleData(external_key=COURSE_ADMIN.external_key)],