Skip to content

Commit 6efb92c

Browse files
authored
fix: Drop mock STATICFILES_STORAGE_KWARGS (#38551)
The setting was misleading, because it doesn't do anything as-is. The code that reads from this dict uses the default of settings.STORAGES['staticfiles']['BACKEND'], which is openedx.core.storage.ProductionStorage, as the key. The data under the defined (and now removed) key openedx.core.storage.ProductionS3Storage would never have been used.
1 parent c38fb07 commit 6efb92c

2 files changed

Lines changed: 0 additions & 9 deletions

File tree

cms/envs/mock.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,10 +739,6 @@ SOCIAL_SHARING_SETTINGS:
739739
DASHBOARD_FACEBOOK: true
740740
DASHBOARD_TWITTER: true
741741
SOFTWARE_SECURE_RETRY_MAX_ATTEMPTS: 5
742-
STATICFILES_STORAGE_KWARGS:
743-
openedx.core.storage.ProductionS3Storage:
744-
bucket_name: static
745-
default_acl: null
746742
STATIC_ROOT_BASE: /edx/var/edxapp/staticfiles
747743
STATIC_URL_BASE: /static/
748744
STUDIO_NAME: Studio

lms/envs/mock.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1108,10 +1108,6 @@ SOCIAL_SHARING_SETTINGS:
11081108
DASHBOARD_TWITTER: true
11091109
SOFTWARE_SECURE_RETRY_MAX_ATTEMPTS: 5
11101110
SOFTWARE_SECURE_VERIFICATION_ROUTING_KEY: hello
1111-
STATICFILES_STORAGE_KWARGS:
1112-
openedx.core.storage.ProductionS3Storage:
1113-
bucket_name: hello
1114-
default_acl: hello
11151111
STATIC_ROOT_BASE: /tmp/static
11161112
STATIC_URL_BASE: /static
11171113
STUDIO_NAME: Studio
@@ -1246,4 +1242,3 @@ ZENDESK_GROUP_ID_MAPPING:
12461242
ZENDESK_OAUTH_ACCESS_TOKEN: test_zendesk_oauth
12471243
ZENDESK_URL: https://12345.zendesk.com
12481244
ZENDESK_USER: daemon@example.com
1249-

0 commit comments

Comments
 (0)