remove legacy video editor code#38466
Merged
Merged
Conversation
farhan
added
the
create-sandbox
farhan
force-pushed
the
farhan/remove-legacy-video-editor
branch
2 times, most recently
from
8f54991 to
bac18da
Compare
farhan
force-pushed
the
farhan/remove-legacy-video-editor
branch
from
bac18da to
4da2f09
Compare
irfanuddinahmad
force-pushed
the
farhan/remove-legacy-video-editor
branch
from
4da2f09 to
0d2bd3a
Compare
irfanuddinahmad
approved these changes
May 6, 2026
Contributor
irfanuddinahmad
left a comment
irfanuddinahmad
left a comment
There was a problem hiding this comment.
LGTM when green.
Since we are not removing the remaining dead code which is rendered via video_block.py's studio_view (timeline constraint?) ... we should track its removal as part of some task.
salman2013
approved these changes
May 6, 2026
Contributor
|
@irfanuddinahmad I believe what you are saying has done here |
Contributor
Author
|
@irfanuddinahmad @salman2013 Here is the relevant story in which we will remove the further legacy code related to the Video Editor which is coupled with the Built In Video Editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #35257
Adding for the information:
We will delete these html pages while removing the Built-In Video Block code.
They exist in the extracted video block as well.