Skip to content

Commit b62efa2

Browse files
authored
fix: remove lms specific waffle check (#312)
* fix: remove lms specific waffle check
1 parent 78cabcf commit b62efa2

4 files changed

Lines changed: 6 additions & 12 deletions

File tree

CHANGELOG.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ Please See the [releases tab](https://github.com/openedx/xblock-lti-consumer/rel
1616
Unreleased
1717
~~~~~~~~~~
1818

19+
7.0.3 - 2022-12-02
20+
------------------
21+
* Removed check against LMS specific `database_config_enabled` in LtiConfiguration model.
22+
1923
7.0.2 - 2022-11-29
2024
------------------
2125
* Fix the LTI 1.1 Outcome Results Service to be able to tie an outcome pass back to a user when the user ID is an

lti_consumer/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
from .apps import LTIConsumerApp
55
from .lti_xblock import LtiConsumerXBlock
66

7-
__version__ = '7.0.2'
7+
__version__ = '7.0.3'

lti_consumer/models.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
get_lti_ags_lineitems_url,
3030
get_lti_deeplinking_response_url,
3131
get_lti_nrps_context_membership_url,
32-
database_config_enabled,
3332
)
3433

3534
log = logging.getLogger(__name__)
@@ -240,10 +239,6 @@ def clean(self):
240239
"config_store": _("LTI Configuration stores on XBlock needs a block location set."),
241240
})
242241
if self.version == self.LTI_1P3 and self.config_store == self.CONFIG_ON_DB:
243-
if not database_config_enabled(self.location.course_key):
244-
raise ValidationError({
245-
"config_store": _("LTI Configuration stores on database is not enabled."),
246-
})
247242
if self.lti_1p3_tool_public_key == "" and self.lti_1p3_tool_keyset_url == "":
248243
raise ValidationError({
249244
"config_store": _(

lti_consumer/tests/unit/test_models.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -359,15 +359,10 @@ def test_clean(self):
359359

360360
self.lti_1p3_config.config_store = self.lti_1p3_config.CONFIG_ON_DB
361361

362-
with patch("lti_consumer.models.database_config_enabled", return_value=False),\
363-
self.assertRaises(ValidationError):
364-
self.lti_1p3_config_db.clean()
365-
366362
self.lti_1p3_config_db.lti_1p3_tool_keyset_url = ''
367363
self.lti_1p3_config_db.lti_1p3_tool_public_key = ''
368364

369-
with patch("lti_consumer.models.database_config_enabled", return_value=True),\
370-
self.assertRaises(ValidationError):
365+
with self.assertRaises(ValidationError):
371366
self.lti_1p3_config_db.clean()
372367

373368
self.lti_1p3_config.lti_1p3_proctoring_enabled = True

0 commit comments

Comments
 (0)