Skip to content

Commit d82a697

Browse files
authored
feat: ProctoringConsumer basic launch request (#388)
1 parent cb33ae5 commit d82a697

4 files changed

Lines changed: 27 additions & 5 deletions

File tree

CHANGELOG.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ Please See the `releases tab <https://github.com/openedx/xblock-lti-consumer/rel
1616
Unreleased
1717
~~~~~~~~~~
1818

19+
9.5.4 - 2023-06-28
20+
------------------
21+
* Allow basic LtiResourceLink launch for an LtiProctoringConsumer
22+
1923
9.5.3 - 2023-06-09
2024
------------------
2125
* Redirect to exam on same LTI proctoring launch tab once ready to start.

lti_consumer/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
from .apps import LTIConsumerApp
55
from .lti_xblock import LtiConsumerXBlock
66

7-
__version__ = '9.5.3'
7+
__version__ = '9.5.4'

lti_consumer/lti_1p3/consumer.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -885,8 +885,13 @@ def generate_launch_request(
885885
self.set_extra_claim(self.get_assessment_control_claim())
886886
elif launch_data.message_type == "LtiEndAssessment":
887887
proctoring_claims = self.get_end_assessment_claims()
888+
elif launch_data.message_type == "LtiResourceLinkRequest":
889+
proctoring_claims = {}
888890
else:
889-
raise ValueError('lti_message_hint must \"LtiStartProctoring\" or \"LtiEndAssessment\".')
891+
raise ValueError(
892+
'lti_message_hint must be \"LtiStartProctoring\" or \"LtiEndAssessment\"'
893+
'or \"LtiResourceLinkRequest\"'
894+
)
890895

891896
self.set_extra_claim(proctoring_claims)
892897

lti_consumer/lti_1p3/tests/test_consumer.py

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,6 +1087,19 @@ def test_generate_launch_request(self, message_type, mock_get_data_from_cache):
10871087
for claim in expected_claims.items():
10881088
self.assertIn(claim, decoded_token_claims)
10891089

1090+
@patch('lti_consumer.lti_1p3.consumer.get_data_from_cache')
1091+
def test_generate_basic_launch_request(self, mock_get_data_from_cache):
1092+
mock_launch_data = self.get_launch_data(message_type="LtiResourceLinkRequest")
1093+
mock_get_data_from_cache.return_value = mock_launch_data
1094+
1095+
self._setup_proctoring()
1096+
token = self.lti_consumer.generate_launch_request(
1097+
self.preflight_response,
1098+
)['id_token']
1099+
1100+
# just check token is valid
1101+
self.lti_consumer.key_handler.validate_and_decode(token)
1102+
10901103
@patch('lti_consumer.lti_1p3.consumer.get_data_from_cache')
10911104
def test_enable_assessment_control(self, mock_get_data_from_cache):
10921105
"""
@@ -1120,11 +1133,11 @@ def test_enable_assessment_control(self, mock_get_data_from_cache):
11201133
@patch('lti_consumer.lti_1p3.consumer.get_data_from_cache')
11211134
def test_generate_launch_request_invalid_message(self, mock_get_data_from_cache):
11221135
"""
1123-
Ensures that a ValueError is raised if the launch_data.message_type is not LtiStartProctoring or
1124-
LtiEndAssessment.
1136+
Ensures that a ValueError is raised if the launch_data.message_type is not LtiStartProctoring,
1137+
LtiEndAssessment, or LtiResourceLinkRequest.
11251138
"""
11261139

1127-
mock_launch_data = self.get_launch_data(message_type="LtiResourceLinkRequest")
1140+
mock_launch_data = self.get_launch_data(message_type="LtiDeepLinkingRequest")
11281141
mock_get_data_from_cache.return_value = mock_launch_data
11291142

11301143
self._setup_proctoring()

0 commit comments

Comments
 (0)