PR #6 unlocked replicas for edit to support standalone→replicated migration and scale-up. Side effect: decreasing replicas on a replicated Instance (e.g. 3→2) passes Validate() (min 2) but chiNeedsReplicatedMigration() only triggers when current < target — so a decrease is silently ignored. The provider neither scales down nor returns an error; the user sees no effect.
Options
- Reject scale-down in
Validate() with a clear error (simplest, ~5 lines), or
- Implement safe scale-down (drain/decommission replica, rebalance).
Ref: PR #6 (topology migration). Found in cold review.
PR #6 unlocked
replicasfor edit to support standalone→replicated migration and scale-up. Side effect: decreasing replicas on a replicated Instance (e.g. 3→2) passesValidate()(min 2) butchiNeedsReplicatedMigration()only triggers whencurrent < target— so a decrease is silently ignored. The provider neither scales down nor returns an error; the user sees no effect.Options
Validate()with a clear error (simplest, ~5 lines), orRef: PR #6 (topology migration). Found in cold review.