Fixes for plugins on Windows

os.ExpandEnv does not work on Windows, and HOME is also set to
an empty-string, so HOMEPATH must be substituted in.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Author: alexellis

commands/faas.go

@@ -8,6 +8,7 @@ import (
 	"log"
 	"os"
 	"path"
+	"runtime"
 	"strings"
 	"syscall"
 
@@ -137,7 +138,12 @@ func runFaas(cmd *cobra.Command, args []string) {
 
 func getPlugins() ([]string, error) {
 	plugins := []string{}
-	pluginHome := os.ExpandEnv("$HOME/.openfaas/plugins")
+	var pluginHome string
+	if runtime.GOOS == "windows" {
+		pluginHome = os.Expand("$HOMEPATH/.openfaas/plugins", os.Getenv)
+	} else {
+		pluginHome = os.ExpandEnv("$HOME/.openfaas/plugins")
+	}
 
 	if _, err := os.Stat(pluginHome); err != nil && os.IsNotExist(err) {
 		return plugins, nil

commands/plugin_get.go

@@ -80,10 +80,17 @@ func runPluginGetCmd(cmd *cobra.Command, args []string) error {
 		fmt.Printf("Fetching plugin: %s\n", pluginName)
 	}
 
-	pluginDir := os.ExpandEnv("$HOME/.openfaas/plugins")
+	var pluginDir string
+	if runtime.GOOS == "windows" {
+		pluginDir = os.Expand("$HOMEPATH/.openfaas/plugins", os.Getenv)
+	} else {
+		pluginDir = os.ExpandEnv("$HOME/.openfaas/plugins")
+	}
 
 	if _, err := os.Stat(pluginDir); os.IsNotExist(err) {
-		os.MkdirAll(pluginDir, 0755)
+		if err := os.MkdirAll(pluginDir, 0755); err != nil && os.ErrExist != err {
+			return fmt.Errorf("failed to create plugin directory %s: %w", pluginDir, err)
+		}
 	}
 
 	tmpTar := path.Join(os.TempDir(), pluginName+".tar")