CloneZero either buggy or confusing

[shaih]

The name suggests that ct->CloneZero() should return an encryption of zero with the bookkeeping information of ct, but this doesn't seem to be the case. For example, the following code coredumps:

    // below slots is an array of slots, cc is CryptoContext, ct is a ciphertext

    Plaintext pt = cc->MakeCKKSPackedPlaintext(slots);
    Ciphertext<DCRTPoly>acc = ct->CloneZero();
    auto tmp = cc->EvalMult(ct, pt);
    cc->EvalAddInPlace(acc, tmp); // <== coredumps in this line

[yspolyakov]

I think CloneZero here actually implies CloneEmpty. I think the extra parameters set in CloneZero should be moved to CloneEmpty, and CloneZero should be removed or implemented differently (to contain an encryption of zero as suggested by @shaih ).