AudioBuffer: comment explaining the try/catch in __getCodec around bytes.getString()

joshtynjala · joshtynjala · commit 15bbc0d911d0 · 2026-01-14T10:24:14.000-08:00
Followup to commit 9b2be25
diff --git a/src/lime/media/AudioBuffer.hx b/src/lime/media/AudioBuffer.hx
@@ -424,7 +424,12 @@ class AudioBuffer
 		{
 			signature = bytes.getString(0, 4);
 		}
-		catch (e:Dynamic) {}
+		catch (e:Dynamic)
+		{
+			// if the bytes don't represent a valid UTF-8 string, getString()
+			// may throw an exception. in that case, we expect to end up in
+			// the default switch case below where it tries to detect MP3.
+		}
 
 		switch (signature)
 		{

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,12 @@ class AudioBuffer`
`424`	`424`	`{`
`425`	`425`	`signature = bytes.getString(0, 4);`
`426`	`426`	`}`
`427`		`- catch (e:Dynamic) {}`
	`427`	`+ catch (e:Dynamic)`
	`428`	`+ {`
	`429`	`+ // if the bytes don't represent a valid UTF-8 string, getString()`
	`430`	`+ // may throw an exception. in that case, we expect to end up in`
	`431`	`+ // the default switch case below where it tries to detect MP3.`
	`432`	`+ }`
`428`	`433`
`429`	`434`	`switch (signature)`
`430`	`435`	`{`