Prices without currency: is it normal?

[monsieurtanuki]

What

For price id 36386, there's no currency. [edited the link]
It means a mild crash in Smoothie, as prices are supposed to have a currency.

Is it now normal to have prices without currencies?

[monsieurtanuki]

Same question for date. Actually it started from openfoodfacts/smooth-app#7216: I wanted to change the order to newest dates first, newest timestamp first, and the records without dates appeared first.

[Kinjal0007]

Opened PR #1124 that addresses this. Let me know if further cleanup or validation logic is preferred!

[raphodn]

Hi !
Some price field rules are based on the price's proof.
And some proofs do not have a currency or date or location.
In the current DB there are 186 prices without date for instance. Last one was created over a year ago.

It's not something we plan to fix in the short run.
On the contrary, were currently experimenting with some specific users the ability to mass-upload receipts without any date & location. that could then be set via AI-assisted UIs. though these proofs won't have any price associated with them (except if barcodes were to be printed on the receipt ?)

In any case, @Kinjal0007 it's nice of you to do a PR, but to avoid wasting everyone's time it's much better to discuss the needs and propose a solution in the related issues, before diving into "solving" something in a PR...

[monsieurtanuki]

@raphodn Assuming that for the moment the dateless prices are rare and very old, date-wise, that means that we're not able in Smoothie to sort by descending date, as null dates come first.
Is there a way to exclude null date records from a price search query? Same for null currency?

Obviously, turning not-null fields into null fields is not something we're quite comfortable with in off-dart and Smoothie.

Could you confirm that all fields on a price are potentially null, including currency, date and price, and excluding id, owner and created?