fix: undefined error in search results loading skeleton

[abrahamvg]

What

Issue

When searching for a product locally on my machine (products/search?q=<name>) I was getting the following error on my console.

client.js?v=68870e34:329 Uncaught (in promise) Svelte error: each_key_duplicate
Keyed each block has duplicate key `undefined` at indexes 0 and 1
https://svelte.dev/e/each_key_duplicate

	in +page.svelte
	in +layout.svelte
	in root.svelte

While reloading the same search result, the results were not getting populated even though the payload was coming in fine.

This issue was resolved for me by updating the loop that generated the ProductCard skeleton from {#each Array(5) as i (i)} to {#each Array(5) as _, i}. Attaching video as well.

Screenshot

https://github.com/user-attachments/assets/01f088be-8832-4bef-a8c4-3089b054f900

Fixes bug(s)

• Duplicate key error because both being undefined in search results loading skeleton #392

[vercel]

@abrahamvg is attempting to deploy a commit to the openfoodfacts Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
openfoodfacts-explorer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2025 0:20am

[VaiTon]

Thank you!

[VaiTon]

@abrahamvg please fix lint errors: https://github.com/openfoodfacts/openfoodfacts-explorer/actions/runs/14178980959/job/39735141397?pr=395

[abrahamvg]

@VaiTon Can I add a rule to only ignore _ variables ?

Code proposed to add :

{
   rules: {
		  '@typescript-eslint/no-unused-vars': ['error', { 
			varsIgnorePattern: '^_$'
		  }]
	  }
}

[VaiTon]

@abrahamvg please run pnpm format ALWAYS before committing (and set up git hooks!)

https://github.com/openfoodfacts/openfoodfacts-explorer/actions/runs/14235091799/job/39916422630?pr=395

[teolemon]

@abrahamvg

[email protected] lint /home/runner/work/openfoodfacts-explorer/openfoodfacts-explorer
prettier --check . && eslint .

Checking formatting...
[warn] eslint.config.mjs
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

[abrahamvg]

@abrahamvg please run pnpm format ALWAYS before committing (and set up git hooks!)

https://github.com/openfoodfacts/openfoodfacts-explorer/actions/runs/14235091799/job/39916422630?pr=395

Appologies for late fix.

@teolemon could you please retrigger the auto-label merge action, once the issue is fixed ?