build(deps): bump jsvectormap from 1.6.0 to 1.7.0 #11978
Conversation
dependabot
bot
added
dependencies
dependabot
bot
added
JavaScript
dependencies
github-project-automation
bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
hangy
left a comment
hangy
left a comment
There was a problem hiding this comment.
Looks like jsvectormap doesn't use semver. Some of the changes like
- refactor: rename jsvectormap.js to jsvectormap.esm.js (afce9da)
- refactor: drop class definition comment from classes (themustafaomar/jsvectormap#164 (a87a1bb))
- refactor: replace deprecated pageY/XOffset with scrollY/X (themustafaomar/jsvectormap#170) (1362f18)
require manual testing/review of our code.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the jsvectormap dependency to v1.7.0 and refactors the map display code to use ESM modules.
- Bumped
jsvectormapfrom^1.6.0to^1.7.0inpackage.json. - Replaced legacy
<script>includes withtype="module"imports in HTML templates and in the Perl renderer. - Converted
display-list-of-tagsto an ESM module and updated the Gulp task to copy the.esm.jsbuild.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/expected_test_results/web_html/world-countries.html | Replaced inline map setup with a <script type="module"> import of display-list-of-tags.esm.js |
| tests/integration/expected_test_results/web_html/fr-countries.html | Same ESM import update for the French countries page |
| package.json | Updated jsvectormap version to ^1.7.0 |
| lib/ProductOpener/Display.pm | Switched from concatenated JS includes to injecting an ESM module snippet for displayWorldMap |
| html/js/display-list-of-tags.esm.js | Exported displayWorldMap and imported jsvectormap.esm.js and world-merc.js as modules |
| gulpfile.ts | Changed copy source from jsvectormap.js to jsvectormap.esm.js |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11978 +/- ##
==========================================
+ Coverage 46.37% 51.76% +5.39%
==========================================
Files 94 96 +2
Lines 24693 24787 +94
Branches 5915 5932 +17
==========================================
+ Hits 11451 12832 +1381
+ Misses 11687 10237 -1450
- Partials 1555 1718 +163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed/updated some stuff and tested fine locally. As I modified stuff, I won't review though 😅 |
teolemon
moved this from To discuss and validate
to PRs
in 🍊 Open Food Facts Server issues
|
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [jsvectormap](https://github.com/themustafaomar/jsvectormap) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/themustafaomar/jsvectormap/releases) - [Commits](themustafaomar/jsvectormap@v1.6.0...v1.7.0) --- updated-dependencies: - dependency-name: jsvectormap dependency-version: 1.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jsvectormap-1.7.0
branch
from
c2b6702 to
51b121a
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
Template::Toolkit
|
/update_tests_results |
|
alexgarel
left a comment
alexgarel
left a comment
There was a problem hiding this comment.
Tested ok on my side ! (on countries facets page). Product edition also still works.
github-project-automation
bot
moved this from PRs
to Done
in 🍊 Open Food Facts Server issues
github-project-automation
bot
moved this to Done
in JavaScript issues across Open Food Facts
|
@dependabot rebase |
|
Sorry, only users with push access can use that command. |
…cts#11978)" This reverts commit 069e371.
Bumps jsvectormap from 1.6.0 to 1.7.0.
Release notes
Sourced from jsvectormap's releases.
Commits
5f77186chore: update readme and package.jsond8467eedocs: update documentation completely (#198)df12f2frefactor: enhance style and drop unwanted props (#197)70ad831fix(lines): curves distorted when it's zero value (#195)7f331berevert: revert old lineStyle config to maintain compatibility (#194)82dbea0fix(tooltip): internal text overrides text from listeners (#192)bb1581erefactor: use css variables to override style (#191)c2cfb10fix: tooltip might be undefined see #126 #179 (#186)e308ad8build: update package dependencies (#187)c2ef7e7refactor: missing using zoomInOption variable at #182You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)