-
-
Notifications
You must be signed in to change notification settings - Fork 506
fix: remove some dead code #12714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: remove some dead code #12714
Conversation
|
/update_tests_results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12714 +/- ##
==========================================
+ Coverage 46.45% 52.22% +5.76%
==========================================
Files 95 96 +1
Lines 24799 24608 -191
Branches 5949 5900 -49
==========================================
+ Hits 11520 12851 +1331
+ Misses 11711 10034 -1677
- Partials 1568 1723 +155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/update_tests_results |
|
alexgarel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: The cordova app should probably be marked as obsolete (potentially archived). We still get some dependabot package upgrades and GitHub action runs for that repo. Also, this should potentially be marked as a breaking change in the changelog, because consumers might be using the API endpoints |



Removing some dead code: