Skip to content

Conversation

@stephanegigandet
Copy link
Contributor

Removing some dead code:

  • support for jquerymobile, used in the Cordova app
  • unused code and templates for product page that have been replaced with knowledge panels

@stephanegigandet
Copy link
Contributor Author

/update_tests_results

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.22%. Comparing base (c87af4d) to head (f08d2a8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/Display.pm 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12714      +/-   ##
==========================================
+ Coverage   46.45%   52.22%   +5.76%     
==========================================
  Files          95       96       +1     
  Lines       24799    24608     -191     
  Branches     5949     5900      -49     
==========================================
+ Hits        11520    12851    +1331     
+ Misses      11711    10034    -1677     
- Partials     1568     1723     +155     
Flag Coverage Δ
integration-test-group-1 31.63% <0.00%> (?)
integration-test-group-2 27.44% <0.00%> (?)
integration-test-group-3 8.88% <0.00%> (?)
integration-test-group-4 10.86% <0.00%> (?)
integration-test-group-5 20.27% <0.00%> (?)
integration-test-group-6 25.20% <0.00%> (?)
integration-test-group-7 10.41% <0.00%> (?)
integration-test-group-8 8.89% <0.00%> (?)
integration-test-group-9 9.10% <0.00%> (?)
unit-test-group-1 26.70% <0.00%> (+0.28%) ⬆️
unit-test-group-2 22.02% <0.00%> (+0.23%) ⬆️
unit-test-group-3 20.86% <0.00%> (+0.22%) ⬆️
unit-test-group-4 31.57% <0.00%> (+0.32%) ⬆️
unit-test-group-5 20.26% <0.00%> (+0.21%) ⬆️
unit-test-group-6 29.68% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Nov 28, 2025
@stephanegigandet
Copy link
Contributor Author

/update_tests_results

@sonarqubecloud
Copy link

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so cool !

image

@github-project-automation github-project-automation bot moved this from Todo to In Progress in 🚦Nutri-Score Nov 28, 2025
@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in 🛠️ - Server - API Nov 28, 2025
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Nov 28, 2025
@hangy
Copy link
Member

hangy commented Nov 28, 2025

Removing some dead code:

* support for jquerymobile, used in the Cordova app

Related: The cordova app should probably be marked as obsolete (potentially archived). We still get some dependabot package upgrades and GitHub action runs for that repo.

Also, this should potentially be marked as a breaking change in the changelog, because consumers might be using the API endpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Display 🚦 Nutri-Score Nutrient levels Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🧪 unit tests

Projects

Status: In Progress
Status: Reviewer approved

Development

Successfully merging this pull request may close these issues.

5 participants