Skip to content

chore: add initial devcontainer.json config#36

Closed
prometheas wants to merge 1 commit intoopenfoodfacts:mainfrom
prometheas:add-dev-container
Closed

chore: add initial devcontainer.json config#36
prometheas wants to merge 1 commit intoopenfoodfacts:mainfrom
prometheas:add-dev-container

Conversation

@prometheas
Copy link
Copy Markdown

What

  • Adds a devcontainer.json config file, enabling containerized development environment using Python 3.9 (the same version of Python used in the root Dockerfile of the repo), to create a development environment consistent with the deployment environment.

Screenshot

N/A

Fixes bug(s)

N/A

Part of

N/A

Using the version of Python 3 matching the version used in the root
`Dockerfile` of the repo (3.9).  The container also includes the
`docker-outside-of-docker` dev container feature.
@alexgarel
Copy link
Copy Markdown
Member

Hi @prometheas, can you explain it a bit to me ? Isn't the docker-compose sufficient ?

If it adds some new capabilities, could you add a small explanation in the README ?

@alexgarel
Copy link
Copy Markdown
Member

And thanks a lot for this first PR @prometheas 🎉

{
"name": "Python 3",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:0-3.9",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the Dockerfile instead ?

@prometheas
Copy link
Copy Markdown
Author

Hi @prometheas, can you explain it a bit to me ? Isn't the docker-compose sufficient ?

If it adds some new capabilities, could you add a small explanation in the README ?

Hi, @alexgarel 👋 this PR adds a Dev Container file to the project, allowing developers to create a uniform development environment. This is notable different to the container used by docker-compose, which offers reliable parity for runtime only (which is not used to, say, run the make scripts or any of the development-level scripts and automations.

Consistent versions of Python and any number of supporting cli tools become trivial, allowing newcomers to get started in minutes, rather than hours or days. Even allows for development directly in the web browser at GitHub Codespaces, or vscode.com.

Good point about updating info in the README, though. Will get on that today.

@teolemon
Copy link
Copy Markdown
Member

@prometheas if you have time, it'd be great having a finalized devcontainer.json

@teolemon teolemon requested a review from Copilot September 19, 2025 11:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a development container configuration to enable consistent containerized development environments using Python 3.9, matching the deployment environment specified in the root Dockerfile.

@areebahmeddd
Copy link
Copy Markdown
Member

This PR is superseded by this: #336

cc: @alexgarel @teolemon

@github-project-automation github-project-automation Bot moved this from Backlog (ready for dev) to Done in 🔎 Search-a-licious Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants