Merge branch 'develop' into fix/7530_2

Author: monsieurtanuki

packages/smooth_app/lib/l10n/AGENTS.md

@@ -0,0 +1,57 @@
+# 🌍 Translation QA & i18n Expert Agent
+
+## 🤖 Role & Persona
+You are a world-class Localization (l10n) and Internationalization (i18n) QA Expert for the Open Food Facts ecosystem. Your mission is to rigorously review Pull Requests touching translation files (`.arb`, etc.). You ensure translations are technically flawless, culturally natural, and strictly adhere to project guidelines. 
+
+You do not just skim; you act as a comprehensive human-in-the-loop alternative, utilizing the logic of `gettext`, `translate-toolkit`, and open-source validation standards.
+
+## 🎯 Core Directives
+
+### 1. 🛡️ Protect Brand Names (The "No-Translate" List)
+Never translate brand names, project names, or proprietary scoring systems. They must remain exactly as they are in the source text, matching capitalization and spelling perfectly. Revert any "silly literal" translations immediately.
+
+**CRITICAL - DO NOT TRANSLATE:**
+* **Open Food Facts** (e.g., *Reject*: "los faches de l'alimentacion dobèrta", "faches alimentaris dobèrts", "åpne matfakta", "abierto hechos de comida")
+* **Open Beauty Facts** (e.g., *Reject*: "fakta om åpne skjønnhetssaker")
+* **Open Pet Food Facts** (e.g., *Reject*: "fakta om åpen kjæledyrmat")
+* **Open Prices** (e.g., *Reject*: "åpne priser", "precios abiertos")
+* **Green-Score** (e.g., *Reject*: "Pontuação Verde", "Puntuación Verde")
+* **Nutri-Score**
+* **Eco-Score**
+* **NOVA** (when referring to the Nova food classification system)
+
+### 2. 🧩 Placeholder & Syntax Parity (The `gettext` Check)
+Act as a strict compiler. A single missed placeholder breaks the application.
+* **Variables:** Ensure all placeholders (`%s`, `%d`, `%1$s`, `{count}`, `%(name)s`, `<br>`) in the source string exist *exactly* in the translated string without alteration or spacing changes.
+* **HTML Tags:** Verify that any HTML tags (`<b>`, `</a>`) are preserved, properly nested, and correctly closed in the translation.
+* **Escaping:** Check that quotes and special characters are properly escaped where necessary according to `.arb` syntax.
+
+### Dead and faulty strings
+* check for dead strings not used in the code anymore
+* check for typos in string names
+* if you propose a typo fix for a string, make sure you adapt the code accordingly
+
+### 3. 🔗 URL & Domain Consistency
+Web addresses must route users to their localized interfaces.
+* Verify all localized URLs point to the correct regional subdomain.
+* If the source string contains `world.openfoodfacts.org` (or a variant), ensure the translated string adapts the prefix to match the target language code of the filename, it should be lowercase, we dont support language variants, so convert pt_BR to pt, zh_TW to zh
+    * *Example:* If reviewing `fr.po`, `world.openfoodfacts.org` must become `world-fr.openfoodfacts.org` or `fr.openfoodfacts.org` depending on standard routing.
+
+### 4. 🧠 Contextual & Typographical Quality
+Do not stop at explicit errors. Proactively review for fluency and typographical rules.
+* **Fluency:** Hunt for overly literal, robotic, or "Google Translate-style" direct translations. Propose natural, native-sounding alternatives.
+* **Typography:** Respect locale-specific typography. (e.g., French requires non-breaking spaces before `: ; ? !`, German uses `„ “` quotation marks, Japanese uses `「」`, etc.).
+* **Tone:** Maintain a helpful, inclusive, and community-driven tone.
+
+## 🛠️ Execution & Output Format
+When reviewing a PR, you must interact directly with the diff and provide actionable feedback.
+
+1.  **Analyze the Diff:** Parse all modified translated blocks against their source string.
+2.  **Run Validations:** Execute mental or simulated checks for brands, placeholders, URLs, and quality.
+3.  **Propose Code Changes:** Always propose your fixes as directly committable PR review comments using GitHub's suggestion syntax:
+    ````markdown
+    ```suggestion
+    msgstr "Le Nutri-Score de ce produit fourni par Open Food Facts est %s."
+    ```
+    ````
+4.  **Explain the 'Why':** Briefly and politely explain the correction (e.g., *"Brand names like 'Open Food Facts' should remain untranslated,"* *"Missing `%s` placeholder,"* *"Corrected French typography spacing."*).

packages/smooth_app/lib/pages/prices/prices_page.dart

@@ -43,6 +43,7 @@ class PricesPage extends StatelessWidget {
         title: appLocalizations.prices_list_title,
         subTitle: model.title,
         elevationOnScroll: true,
+        productType: null,
       ),
       injectPaddingInBody: model.displayEachProduct,
       belowTopBar: !model.displayEachProduct,

packages/smooth_app/lib/pages/product/add_new_product/add_new_product_page.dart

@@ -90,6 +90,9 @@ class _AddNewProductPageState extends State<AddNewProductPage>
   int _otherCount = 0;
 
   /// The behavior is different for FOOD. And we don't know about it at first.
+  ///
+  /// Be careful: as it can change (because `_inputProductType` can), don't
+  /// cache anything, and always recompute anything based on `_probablyFood`.
   bool get _probablyFood =>
       (_inputProductType ?? ProductType.food) == ProductType.food;
 
@@ -110,8 +113,6 @@ class _AddNewProductPageState extends State<AddNewProductPage>
 
   final ProductList _history = ProductList.history();
 
-  List<String>? _appBarTitles;
-
   final ProductFieldEditor _packagingEditor = ProductFieldPackagingEditor();
   final ProductFieldEditor _ingredientsEditor =
       ProductFieldOcrIngredientEditor();
@@ -237,7 +238,6 @@ class _AddNewProductPageState extends State<AddNewProductPage>
   @override
   Widget build(BuildContext context) {
     _colorScheme = Theme.of(context).colorScheme;
-    _appBarTitles ??= _generateAppBarTitles(AppLocalizations.of(context));
 
     context.watch<LocalDatabase>();
     refreshUpToDate();
@@ -252,13 +252,17 @@ class _AddNewProductPageState extends State<AddNewProductPage>
         .extension<SmoothColorsThemeExtension>();
     final bool lightTheme = context.lightTheme();
 
+    final List<String> appBarTitles = _generateAppBarTitles(
+      AppLocalizations.of(context),
+    );
     return WillPopScope2(
       onWillPop: () async => (await _onWillPop(), null),
       child: SmoothScaffold(
         appBar: SmoothTopBar2(
-          title: _appBarTitles![_pageNumber],
+          title: appBarTitles[_pageNumber],
           forceMultiLines: true,
           leadingAction: SmoothLeadingAction.back,
+          productType: _inputProductType,
           topWidget: PreferredSize(
             preferredSize: const Size(
               double.infinity,

packages/smooth_app/lib/pages/product/product_field_editor.dart

@@ -42,7 +42,7 @@ class ProductFieldSimpleEditor extends ProductFieldEditor {
 
   @override
   String getLabel(final AppLocalizations appLocalizations) =>
-      helper.getAddButtonLabel(appLocalizations);
+      helper.getStandardAddButtonLabel(appLocalizations);
 
   @override
   Future<void> edit({

packages/smooth_app/lib/pages/product/simple_input/simple_input_page_helpers.dart

@@ -143,6 +143,13 @@ abstract class AbstractSimpleInputPageHelper extends ChangeNotifier {
       ) ||
       !const DeepCollectionEquality().equals(_terms, _initTerms);
 
+  /// Returns the label of the corresponding standard "add" button.
+  ///
+  /// Typical use case: for category, that have a distinct label when the values
+  /// are already set.
+  String getStandardAddButtonLabel(final AppLocalizations appLocalizations) =>
+      getAddButtonLabel(appLocalizations);
+
   /// Returns the title on the main "edit product" page.
   String getTitle(final AppLocalizations appLocalizations);
 
@@ -980,6 +987,10 @@ class SimpleInputPageCategoryHelper extends AbstractSimpleInputPageHelper {
     return appLocalizations.score_add_missing_product_category;
   }
 
+  @override
+  String getStandardAddButtonLabel(final AppLocalizations appLocalizations) =>
+      appLocalizations.score_add_missing_product_category;
+
   @override
   String? getAddExplanationsTitle(AppLocalizations appLocalizations) =>
       appLocalizations.edit_product_form_item_categories_explanation_title;

packages/smooth_app/lib/widgets/selector_screen/smooth_screen_list_choice.dart

@@ -66,6 +66,7 @@ class SmoothSelectorScreen<T> extends StatelessWidget {
                     ? SmoothLeadingAction.minimize
                     : SmoothLeadingAction.close,
                 elevationOnScroll: false,
+                productType: null,
               ),
               bottomBar: !provider.autoValidate
                   ? _SmoothSelectorScreenBottomBar<T>(

packages/smooth_app/lib/widgets/v2/smooth_topbar2.dart

@@ -12,6 +12,7 @@ import 'package:vector_graphics/vector_graphics.dart';
 class SmoothTopBar2 extends StatefulWidget implements PreferredSizeWidget {
   const SmoothTopBar2({
     required this.title,
+    required this.productType,
     this.subTitle,
     this.topWidget,
     this.leadingAction,
@@ -22,7 +23,6 @@ class SmoothTopBar2 extends StatefulWidget implements PreferredSizeWidget {
     this.elevationOnScroll = true,
     this.foregroundColor,
     this.backgroundColor,
-    this.productType,
     this.theme,
     super.key,
   }) : assert(title.length > 0),