feat: Added price count badges #6493

asim-sahoo · 2025-03-29T11:52:37Z

What

Added a price count badge to proof details and grid view for better visibility.
Refactored ProofGridItem for a cleaner layout and better readability.
Adjusted container styling for better readability.

Screenshot

Fixes bug(s)

Fixes: Show price count in more places on proofs #6479

monsieurtanuki

Hi @asim-sahoo!
Some things to change in your code, as you can read in my comments. And probably more, later.
Btw in your screenshots you don't show proofs but product images. I hope you didn't pollute the PROD server with irrelevant pictures - you tested prices on DEV/TEST, right?

monsieurtanuki · 2025-03-30T05:59:05Z

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

Please remove that file from the PR, it has nothing to do with your code.

the changes were auto generated, I have reverted the changes but its still showing in the changed files.
same with the .gitignore file. I have no idea why its showing changed although there is no difference. can you please help me with this

monsieurtanuki · 2025-03-30T06:03:00Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

@@ -26,6 +26,7 @@ class PriceProofPage extends StatefulWidget {

 class _PriceProofPageState extends State<PriceProofPage> {
  List<Price>? _existingPrices;
+  bool _isLoading = true;


_isLoading has no purpose in your code, so please remove it.

monsieurtanuki · 2025-03-30T06:03:51Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+          ),
+          // Display price count badge on the detail screen
+          if (!_isLoading && _existingPrices != null)
+            Positioned(


Instead of a Stack and a Positioned, please just us a Badge, cf. prices_card.dart.

@asim-sahoo ping

monsieurtanuki · 2025-03-30T06:10:07Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+      setState(() {
+        _isLoading = false;
+      });


Suggested change

setState(() {

_isLoading = false;

});

monsieurtanuki · 2025-03-30T06:10:22Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+      setState(() {
+        _isLoading = false;
+      });


Suggested change

setState(() {

_isLoading = false;

});

monsieurtanuki · 2025-03-30T06:15:58Z

packages/smooth_app/lib/pages/prices/prices_proofs_page.dart

+/// Created a simplified version of _PriceProofImage if needed for transition
+class PriceProofImage extends StatelessWidget {
+  const PriceProofImage(


Just trying to understand: you're creating dead code, and you want it to be public instead of private, right?

monsieurtanuki · 2025-03-30T06:19:00Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+}
+
+/// Widget to display a grid of proofs with price count badges
+class ProofGridItem extends StatefulWidget {


I may be old-fashioned but what is that code doing here in an unrelated file?

Assuming that this code is useful, it should be either in a specific file OR in a place where it makes sense, for instance where it's used, that is prices_proofs_page.dart, where there is a grid.

monsieurtanuki · 2025-03-30T06:21:46Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+
+  Future<void> _loadPrices() async {
+    if (PriceModel.isProofNotGoodEnough(widget.proof)) {
+      setState(() {


For the record you're supposed to check if(mounted) before setState in an async code.

monsieurtanuki · 2025-03-30T06:26:23Z

packages/smooth_app/lib/pages/prices/prices_proofs_page.dart

+                              // Used our new ProofGridItem widget
+                              child: ProofGridItem(


Just put your change into the existing code, in that case in _PriceProofImage.

monsieurtanuki · 2025-03-30T06:27:36Z

packages/smooth_app/lib/pages/prices/price_proof_page.dart

+    setState(() {
+      _existingPrices = prices.value.items ?? <Price>[];
+      _isLoading = false;
+    });


Suggested change

setState(() {

_existingPrices = prices.value.items ?? <Price>[];

_isLoading = false;

});

_existingPrices = prices.value.items ?? <Price>[];

if (mounted) {

setState(() {});

}

…o/smooth-app into feature-price-proof-ui

This reverts commit 388b039.

asim-sahoo · 2025-03-30T08:24:12Z

@monsieurtanuki I’ve made all the requested changes. Since this is my first PR and I’m still learning, I might have made a few mistakes. I’d really appreciate your review. Thanks!

asim-sahoo · 2025-03-30T08:28:29Z

Hi @asim-sahoo! Some things to change in your code, as you can read in my comments. And probably more, later. Btw in your screenshots you don't show proofs but product images. I hope you didn't pollute the PROD server with irrelevant pictures - you tested prices on DEV/TEST, right?

Could you clarify this for me? I ran the app using Flutter and created an account to test the feature. Is there anything else I need to do to ensure the testing was done correctly?
Also in the screenshots I have shown that the Prices count badges which are needed according to the issue have been added.

monsieurtanuki

@asim-sahoo Generally speaking, in this PR you're not asked to be inventive, you're asked to be lazy:

just add a Badge on top of proof images in both proof grid and proof page cases
as this badge is being used in 2 places, it does make sense to make a specific class in a specific file for that

Oh, and please don't push again and again while someone's reviewing your code.

monsieurtanuki · 2025-03-30T08:48:07Z

packages/smooth_app/lib/pages/prices/prices_proofs_page.dart

-                              child: _PriceProofImage(proof,
-                                  squareSize: squareSize),
+                              },
+


Your code needs to be systematically formatted.
Have a look at Android Studio on how to make it automatic.

monsieurtanuki · 2025-03-30T08:49:34Z

.gitignore

We don't want to see this file here.
Add some spaces here and here, make it as it used to be, whatever, this file doesn't belong here.

I've reverted all the changes to their original state, but they are still appearing in the changed section. Additionally, I don’t see any differences in the files so I dont know what to do. Could you please advise on how to resolve this?

monsieurtanuki · 2025-03-30T08:49:45Z

packages/smooth_app/macos/Flutter/GeneratedPluginRegistrant.swift

We don't want to see this file here.
Add some spaces here and here, make it as it used to be, whatever, this file doesn't belong here.

I've reverted all the changes to their original state, but they are still appearing in the changed section. Additionally, I don’t see any differences in the files so I dont know what to do. Could you please advise on how to resolve this?

monsieurtanuki · 2025-03-30T08:53:31Z

packages/smooth_app/lib/pages/prices/prices_card.dart

+/// Badge showing the number of prices with a payment icon
+class PriceBadge extends StatelessWidget {


Please keep it simple and just use a Badge, as already mentioned. And forget about your additional icon.

If you really want to create your own widget - to be used in both proof grid and single proof pages:

create a specific file, like proof_badge.dart

create a specific widget, like ProofBadge

monsieurtanuki · 2025-03-30T08:55:31Z

packages/smooth_app/lib/pages/prices/prices_proofs_page.dart

+class _PriceProofImage extends StatefulWidget {
+  const _PriceProofImage({
+    required this.proof,
+    required this.onTap,


What's the point of changing the parameters?

monsieurtanuki · 2025-03-30T09:07:40Z

Could you clarify this for me? I ran the app using Flutter and created an account to test the feature. Is there anything else I need to do to ensure the testing was done correctly? Also in the screenshots I have shown that the Prices count badges which are needed according to the issue have been added.

You did add crap data to the prices PROD server. Those are not proof images. Proofs are related to prices, they can be receipts or price tags.
If you want to have more freedom to play, you can go in the app to the "Profile" tab, "Contribute", "Software development", "Activate the dev mode", then go to the "dev mode" and set the servers to TEST instead of PROD.
For your supposed "proofs", now it's too late anyway. That's not dramatic, but generally speaking be careful where you create data, it might be in PROD environment.

…ceProofPage

asim-sahoo · 2025-03-30T10:37:18Z

Could you clarify this for me? I ran the app using Flutter and created an account to test the feature. Is there anything else I need to do to ensure the testing was done correctly? Also in the screenshots I have shown that the Prices count badges which are needed according to the issue have been added.

You did add crap data to the prices PROD server. Those are not proof images. Proofs are related to prices, they can be receipts or price tags. If you want to have more freedom to play, you can go in the app to the "Profile" tab, "Contribute", "Software development", "Activate the dev mode", then go to the "dev mode" and set the servers to TEST instead of PROD. For your supposed "proofs", now it's too late anyway. That's not dramatic, but generally speaking be careful where you create data, it might be in PROD environment.

Apologies for that. I'll make sure to be more cautious in the future. I appreciate the clarification regarding proof images and the importance of distinguishing between PROD and TEST environments. Moving forward, I'll use the TEST server for development and testing to avoid adding unintended data.
Once this issue is resolved, I'll remove my account to ensure that no dummy data remains in the system. Thanks for your patience and guidance!

asim-sahoo · 2025-03-30T10:38:51Z

@monsieurtanuki I have made the changes. please review and tell me if further changes is required or not.

teolemon · 2025-03-31T12:52:36Z

Also the build is red because of:
info • Missing type annotation • packages/smooth_app/lib/pages/prices/price_proof_page.dart:82:19 • always_specify_types
warning • Unused import: 'package:auto_size_text/auto_size_text.dart' • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:1:8 • unused_import
warning • Unused import: 'package:smooth_app/generic_lib/design_constants.dart' • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:7:8 • unused_import
warning • The left operand can't be null, so the right operand is never executed • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:207:48 • dead_null_aware_expression

asim-sahoo · 2025-03-31T15:07:30Z

Also the build is red because of: info • Missing type annotation • packages/smooth_app/lib/pages/prices/price_proof_page.dart:82:19 • always_specify_types warning • Unused import: 'package:auto_size_text/auto_size_text.dart' • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:1:8 • unused_import warning • Unused import: 'package:smooth_app/generic_lib/design_constants.dart' • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:7:8 • unused_import warning • The left operand can't be null, so the right operand is never executed • packages/smooth_app/lib/pages/prices/prices_proofs_page.dart:207:48 • dead_null_aware_expression

fixed

codecov-commenter · 2025-04-01T11:40:12Z

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 5.88%. Comparing base (4d9c7fc) to head (6bc0b79).
Report is 823 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../smooth_app/lib/pages/prices/price_proof_page.dart	0.00%	17 Missing ⚠️
...mooth_app/lib/pages/prices/prices_proofs_page.dart	0.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6493      +/-   ##
==========================================
- Coverage     9.54%   5.88%   -3.67%     
==========================================
  Files          325     496     +171     
  Lines        16411   29556   +13145     
==========================================
+ Hits          1567    1739     +172     
- Misses       14844   27817   +12973

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

just trying

Enhanced price proof UI and added price count badges.

0018cc4

github-project-automation bot moved this to 💬 To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 29, 2025

github-project-automation bot added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 29, 2025

github-actions bot added the 🖥️ MacOS label Mar 29, 2025

github-actions bot assigned asim-sahoo Mar 29, 2025

Apply dart formatting

6733ba6

monsieurtanuki self-requested a review March 30, 2025 05:44

Merge branch 'develop' into feature-price-proof-ui

ab6e51d

monsieurtanuki reviewed Mar 30, 2025

View reviewed changes

asim-sahoo added 9 commits March 30, 2025 12:58

Removed GeneratedPluginRegistrant.swift from PR

0a85671

Merge branch 'feature-price-proof-ui' of https://github.com/asim-saho…

13fc402

…o/smooth-app into feature-price-proof-ui

Ignore GeneratedPluginRegistrant.swift

5d0ce55

Restored GeneratedPluginRegistrant.swift

47b594b

Restored GeneratedPluginRegistrant.swift

a2781da

Merge branch 'feature-price-proof-ui' of https://github.com/asim-saho…

06b05d6

…o/smooth-app into feature-price-proof-ui

Remove .gitignore file

388b039

Revert "Remove .gitignore file"

e178547

This reverts commit 388b039.

Revert .gitignore file

8304a52

github-actions bot added the Prices label Mar 30, 2025

github-project-automation bot added this to 💸 Open Prices Mar 30, 2025

github-project-automation bot moved this to Backlog in 💸 Open Prices Mar 30, 2025

Apply dart formatting

f8c6f65

monsieurtanuki reviewed Mar 30, 2025

View reviewed changes

Remove PriceBadge component and replace it with a custom badge in Pri…

0618978

…ceProofPage

removed unused imports fixed

a9d2ceb

Merge branch 'develop' into feature-price-proof-ui

990b3be

Merge branch 'develop' into feature-price-proof-ui

ec91ea7

g123k changed the title ~~feat: Added price count badges.~~ feat: Added price count badges Apr 3, 2025

asim-sahoo and others added 3 commits April 5, 2025 18:58

Merge branch 'develop' into feature-price-proof-ui

009560f

Update .gitignore

d94b876

just trying

Update GeneratedPluginRegistrant.swift

6bc0b79

just trying

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added price count badges #6493

feat: Added price count badges #6493

asim-sahoo commented Mar 29, 2025

monsieurtanuki left a comment

monsieurtanuki Mar 30, 2025

asim-sahoo Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Apr 5, 2025

asim-sahoo Apr 6, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

asim-sahoo commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025 •

edited

Loading

monsieurtanuki left a comment

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

asim-sahoo Mar 30, 2025

monsieurtanuki Mar 30, 2025

asim-sahoo Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki Mar 30, 2025

monsieurtanuki commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025

teolemon commented Mar 31, 2025

asim-sahoo commented Mar 31, 2025

codecov-commenter commented Apr 1, 2025 •

edited

Loading

		/// Badge showing the number of prices with a payment icon
		class PriceBadge extends StatelessWidget {

feat: Added price count badges #6493

Are you sure you want to change the base?

feat: Added price count badges #6493

Conversation

asim-sahoo commented Mar 29, 2025

What

Screenshot

Fixes bug(s)

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asim-sahoo commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025 • edited Loading

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monsieurtanuki commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025

asim-sahoo commented Mar 30, 2025

teolemon commented Mar 31, 2025

asim-sahoo commented Mar 31, 2025

codecov-commenter commented Apr 1, 2025 • edited Loading

Codecov Report

asim-sahoo commented Mar 30, 2025 •

edited

Loading

codecov-commenter commented Apr 1, 2025 •

edited

Loading