Skip to content

fix: 6560 - explicit readyForPriceTagValidation parameter for proof upload #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: 6560 - explicit readyForPriceTagValidation parameter for proof upload #6573

wants to merge 2 commits into from

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now we explicitly set the new "readyForPriceTagValidation" parameter for proof uploads.
  • That means that bulk proof uploads will from now on be considered as "ready for price tag validation".
  • For the moment we set it to true for all price tags and false for all receipts, but that may be amended later.

Fixes bug(s)

Impacted files

  • background_task_add_price.dart: added explicit readyForPriceTagValidation parameter for proof upload
  • pubspec.lock: wtf
  • pubspec.yaml: upgraded openfoodfacts to 3.22.0

@monsieurtanuki
fix: 6560 - explicit readyForPriceTagValidation parameter for proof u…
1dcccb9 
…pload

Impacted files:
* `background_task_add_price.dart`: added explicit `readyForPriceTagValidation` parameter for proof upload
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded `openfoodfacts` to `3.22.0`
@monsieurtanuki monsieurtanuki requested a review from teolemon May 2, 2025 09:43
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.

Project coverage is 5.81%. Comparing base (4d9c7fc) to head (0f61348).
Report is 857 commits behind head on develop.

Files with missing lines Patch % Lines
...smooth_app/lib/pages/prices/prices_stats_page.dart 0.00% 102 Missing ⚠️
..._app/lib/background/background_task_add_price.dart 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop   #6573      +/-   ##
==========================================
- Coverage     9.54%   5.81%   -3.74%     
==========================================
  Files          325     501     +176     
  Lines        16411   29993   +13582     
==========================================
+ Hits          1567    1745     +178     
- Misses       14844   28248   +13404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teolemon teolemon requested a review from a team May 3, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon Awaiting requested review from teolemon

At least 1 approving review is required to merge this pull request.

Assignees

@monsieurtanuki monsieurtanuki

Labels
🔁 Background tasks dependencies Prices
Projects
💸 Open Prices
Status: Backlog
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 💬 To discuss and validate
Milestone
No milestone
2 participants
@monsieurtanuki @codecov-commenter