fix(vector): forward offline spatial-extension path to the Add Vector panel (#446)

* fix(vector): forward offline spatial-extension path to the Add Vector panel

The Add Vector panel's maplibre-gl-vector control runs its own DuckDB-WASM
engine, which installs the spatial extension from a remote repository. In
sandboxed or firewalled environments that install hangs, leaving the panel
stuck on "Loading DuckDB-WASM..." (#445).

Forward VITE_DUCKDB_SPATIAL_EXTENSION_PATH (the same variable GeoLibre's own
DuckDB loader honours) to the control via its new spatialExtensionPath option,
so it loads a local extension instead of the remote INSTALL. The helper reads
the runtime env through @geolibre/core so the plugin package does not depend on
the desktop app.

Requires maplibre-gl-vector with the spatialExtensionPath option
(opengeos/maplibre-gl-vector#17).

* chore(deps): bump maplibre-gl-vector to ^0.4.0

0.4.0 publishes the spatialExtensionPath option this branch consumes
(opengeos/maplibre-gl-vector#17), so the dependency range must include it.
Bumps both workspaces (apps/geolibre-desktop, packages/plugins) and the
lockfile to the published 0.4.0.

* Address Claude review feedback

- Centralize getSpatialExtensionPath in @geolibre/core (runtime-env.ts) and
  export it, replacing the line-for-line duplicate that lived in the plugin.
  Both consumers (desktop duckdb loader via the spatial-extension-config
  re-export, and the maplibre-vector plugin) now share one implementation, so
  the VITE_DUCKDB_SPATIAL_EXTENSION_PATH logic cannot silently diverge.
- Drop the now-redundant tests/vector-spatial-extension-path.test.ts; the same
  logic is covered by tests/spatial-extension-config.test.ts.

* Address Claude review feedback

- Simplify getSpatialExtensionPath: single trim via optional chaining
  (`value?.trim() || undefined`) instead of trimming twice.

Author: giswqs

apps/geolibre-desktop/package.json

@@ -74,7 +74,7 @@
     "maplibre-gl-streetview": "^0.6.0",
     "maplibre-gl-swipe": "^0.7.1",
     "maplibre-gl-time-slider": "^1.0.3",
-    "maplibre-gl-vector": "^0.3.0",
+    "maplibre-gl-vector": "^0.4.0",
     "openai": "^6.39.0",
     "qrcode.react": "^4.2.0",
     "react": "^19.2.7",

apps/geolibre-desktop/src/lib/spatial-extension-config.ts

@@ -1,9 +1,5 @@
-import { getRuntimeEnvironment } from "@geolibre/core";
-
-export function getSpatialExtensionPath(
-  env?: Record<string, string | undefined>,
-): string | undefined {
-  const runtimeEnv = env ?? getRuntimeEnvironment();
-  const value = runtimeEnv.VITE_DUCKDB_SPATIAL_EXTENSION_PATH;
-  return value && value.trim() ? value.trim() : undefined;
-}
+// The shared implementation lives in @geolibre/core so the desktop loader and
+// the maplibre-gl-vector plugin resolve VITE_DUCKDB_SPATIAL_EXTENSION_PATH the
+// same way. Re-exported here to keep this module path stable for existing
+// importers (sql-workspace, duckdb-vector-loader, ...).
+export { getSpatialExtensionPath } from "@geolibre/core";

package-lock.json

@@ -71,4 +71,4 @@ export {
   type GeocodeRequest,
   type ReverseGeocodeDisplay,
 } from "./geocoding";
-export { getRuntimeEnvironment } from "./runtime-env";
+export { getRuntimeEnvironment, getSpatialExtensionPath } from "./runtime-env";

packages/core/src/index.ts

@@ -27,3 +27,25 @@ export function getRuntimeEnvironment(): Record<string, string | undefined> {
     ...(window.__GEOLIBRE_RUNTIME_ENV__ ?? {}),
   };
 }
+
+/**
+ * Resolves a local DuckDB spatial extension path from the runtime environment.
+ *
+ * When `VITE_DUCKDB_SPATIAL_EXTENSION_PATH` is set, DuckDB consumers (the
+ * desktop app's own loader and the Add Vector panel's maplibre-gl-vector
+ * control) load the spatial extension from this path with `LOAD '<path>'`
+ * instead of installing it from the remote repository, which hangs in
+ * sandboxed or firewalled environments. Lives in `@geolibre/core` so every
+ * consumer shares one implementation.
+ *
+ * @param env - Environment record (defaults to the runtime environment);
+ *   injectable for testing.
+ * @returns The trimmed extension path, or undefined when unset.
+ */
+export function getSpatialExtensionPath(
+  env?: Record<string, string | undefined>,
+): string | undefined {
+  const runtimeEnv = env ?? getRuntimeEnvironment();
+  const trimmed = runtimeEnv.VITE_DUCKDB_SPATIAL_EXTENSION_PATH?.trim();
+  return trimmed || undefined;
+}

packages/core/src/runtime-env.ts

@@ -48,7 +48,7 @@
     "maplibre-gl-streetview": "^0.6.0",
     "maplibre-gl-swipe": "^0.7.1",
     "maplibre-gl-time-slider": "^1.0.3",
-    "maplibre-gl-vector": "^0.3.0",
+    "maplibre-gl-vector": "^0.4.0",
     "proj4": "^2.20.9",
     "shpjs": "^6.2.0",
     "three": "^0.184.0"

packages/plugins/package.json

@@ -1,4 +1,4 @@
-import { useAppStore } from "@geolibre/core";
+import { getSpatialExtensionPath, useAppStore } from "@geolibre/core";
 import type {
   VectorControl,
   VectorControlEventHandler,
@@ -301,6 +301,9 @@ function createVectorControl(
     panelWidth: 380,
     title: "Add Vector Layer",
     urlPlaceholder: DEFAULT_VECTOR_URL,
+    // Skip the remote spatial-extension install in offline/sandboxed
+    // environments when a local extension path is configured.
+    spatialExtensionPath: getSpatialExtensionPath(),
   });
 
   for (const event of ["layeradded", "layerremoved", "layerupdated"] as const) {