Let go of the 1-hour-long network request timeout to avoid frozen projects #6856
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
reasonable_timeout
branch
from
b83b06f to
4a4a363
Compare
Collaborator
|
🎉 Ta-daaa, freshly created APKs are available for 4a4a363: arm64-android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts our app-wide network request timeout away from 1 hour to 1 minute of inactivity. I've also relocated the setting away from the QFieldCloudConnection class into QgisMobileApp since it impacts every request across the board (including WMS/WFS/AFS/AMS/etc. providers).
Discovered this 1-hour timeout while dissecting a user project that would "freeze" QField. Indeed, a one hour wait for a dead server does feel like a frozen app 😆