Skip to content

Commit 86ce0a8

Browse files
authored
Merge pull request #1470 from opengisch/tests-custom-assert-formatting
Testing: Consistently use camelCase for custom assert methods.
2 parents 26420ec + ed64b54 commit 86ce0a8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

docker-app/qfieldcloud/core/tests/test_project.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -402,39 +402,39 @@ def test_private_project_memberships(self):
402402

403403
self.client.raise_request_exception = True
404404

405-
def assert_no_role():
405+
def assertNoRole():
406406
response = self.client.get(apiurl, follow=True)
407407
self.assertEqual(response.status_code, 403)
408408

409-
def assert_role(role, origin):
409+
def assertRole(role, origin):
410410
response = self.client.get(apiurl, follow=True)
411411
self.assertEqual(response.status_code, 200)
412412
json = response.json()
413413
self.assertEqual(json["user_role"], role)
414414
self.assertEqual(json["user_role_origin"], origin)
415415

416416
# Project is public, we have a public role
417-
assert_role("reader", "public")
417+
assertRole("reader", "public")
418418

419419
# Project is public, collaboration membership is valid
420420
ProjectCollaborator.objects.create(
421421
project=p, collaborator=self.user1, role=ProjectCollaborator.Roles.MANAGER
422422
)
423-
assert_role("manager", "collaborator")
423+
assertRole("manager", "collaborator")
424424

425425
# If project is made private, the collaboration is invalid
426426
p.is_public = False
427427
p.save()
428-
assert_no_role()
428+
assertNoRole()
429429

430430
# Making the owner an organization is not enough as user is not member of that org
431431
p.owner = o
432432
p.save()
433-
assert_no_role()
433+
assertNoRole()
434434

435435
# As the user must be member of the organization
436436
OrganizationMember.objects.create(organization=o, member=self.user1)
437-
assert_role("manager", "collaborator")
437+
assertRole("manager", "collaborator")
438438

439439
def test_add_project_collaborator_without_being_org_member(self):
440440
u1 = Person.objects.create(username="u1")

0 commit comments

Comments
 (0)