Skip to content

Commit 6e7db68

Browse files
committed
fix: semver checking
1 parent 6a473a3 commit 6e7db68

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

Diff for: cmd/root.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ func Execute() {
175175
if runningPlg == nil {
176176
return fmt.Errorf("running plugin not found: %s", plg.Config.Name)
177177
}
178-
179-
if semver.Compare(version.VERSION, runningPlg.Plugin.Config.MinKaytuVersion) == -1 {
180-
return fmt.Errorf("plugin requires kaytu version %s, please update your Kaytu CLI", plg.Config.MinKaytuVersion)
178+
if runningPlg.Plugin.Config.MinKaytuVersion != "" && semver.Compare("v"+version.VERSION, runningPlg.Plugin.Config.MinKaytuVersion) == -1 {
179+
return fmt.Errorf("plugin requires kaytu version %s, please update your Kaytu CLI", runningPlg.Plugin.Config.MinKaytuVersion)
181180
}
182181

183182
flagValues := map[string]string{}

Diff for: pkg/plugin/manager.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ func (m *Manager) Install(addr, token string, unsafe bool) error {
293293

294294
plugins[addr] = &m.GetPlugin(addr).Plugin
295295

296-
if semver.Compare(version.VERSION, plugins[addr].Config.MinKaytuVersion) == -1 {
296+
if semver.Compare("v"+version.VERSION, plugins[addr].Config.MinKaytuVersion) == -1 {
297297
return fmt.Errorf("plugin requires kaytu version %s, please update your Kaytu CLI", plugins[addr].Config.MinKaytuVersion)
298298
}
299299
break

Diff for: pkg/server/update.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func CheckForUpdate() error {
1818
return err
1919
}
2020

21-
if cfg.LastVersion != "" && semver.Compare(cfg.LastVersion, version.VERSION) > 0 {
21+
if cfg.LastVersion != "" && semver.Compare(cfg.LastVersion, "v"+version.VERSION) > 0 {
2222
fmt.Println("There's a new version for Kaytu CLI. Update it to latest version and enjoy the new features.")
2323
time.Sleep(2 * time.Second)
2424
return nil

0 commit comments

Comments
 (0)