test 2

Author: KenLSM

.github/workflows/deploy-ecs.yml

@@ -157,19 +157,6 @@ jobs:
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v2
 
-      - name: DEBUG Copy Static Assets from Docker Image and Push to S3
-        env:
-          S3_STATIC_ASSETS_BUCKET_NAME: ${{ secrets.S3_STATIC_ASSETS_BUCKET_NAME }}
-          ECR_REPOSITORY: ${{ inputs.ecr-repository }}
-          ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
-        run: |
-          mkdir -p /tmp/s3static
-          chmod 777 /tmp/s3static
-          echo $ECR_REPOSITORY
-          docker pull $ECR_REGISTRY/formsg:github-actions-cf0bd8d7c04e139afc56a4041448617f4c83ee2f-17069160720-1
-          docker run --rm -v /tmp/s3static:/tmp/s3static $ECR_REGISTRY/formsg:github-actions-cf0bd8d7c04e139afc56a4041448617f4c83ee2f-17069160720-1 cp -r ./dist/frontend/. /tmp/s3static
-          aws s3 sync /tmp/s3static s3://$S3_STATIC_ASSETS_BUCKET_NAME
-
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
@@ -221,10 +208,11 @@ jobs:
         env:
           S3_STATIC_ASSETS_BUCKET_NAME: ${{ secrets.S3_STATIC_ASSETS_BUCKET_NAME }}
           ECR_REPOSITORY: ${{ inputs.ecr-repository }}
+          ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
         run: |
           mkdir -p /tmp/s3static
           chmod 777 /tmp/s3static
-          docker run --rm -v /tmp/s3static:/tmp/s3static $ECR_REPOSITORY:$IMAGE_TAG cp -r ./dist/frontend/. /tmp/s3static
+          docker run --rm -v /tmp/s3static:/tmp/s3static $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG cp -r ./dist/frontend/. /tmp/s3static
           aws s3 sync /tmp/s3static s3://$S3_STATIC_ASSETS_BUCKET_NAME
 
       - name: Deploy Amazon ECS task definition