added formatMyInfoStorageResponseTests, removed console testing logs

Author: scottheng96

src/app/modules/myinfo/myinfo.service.ts

@@ -389,8 +389,6 @@ export class MyInfoServiceClass {
       },
     ).andThen((hashes) => {
       if (hashes) {
-        console.log('hashes!')
-        console.log(hashes)
         return okAsync(hashes)
       } else {
         logger.info({

src/app/modules/submission/encrypt-submission/__tests__/encrypt-submission.utils.spec.ts

@@ -6,6 +6,7 @@ import { IPopulatedEncryptedForm, StorageModeSubmissionData } from 'src/types'
 
 import {
   createStorageModeSubmissionDto,
+  formatMyInfoStorageResponseData,
   getPaymentAmount,
   getPaymentIntentDescription,
 } from '../encrypt-submission.utils'
@@ -150,4 +151,80 @@ describe('encrypt-submission.utils', () => {
       expect(result).toContain(expectedValue)
     })
   })
+
+  describe('formatMyInfoStorageResponseData', () => {
+    it('should return original responses when no hashed fields are provided', () => {
+      // Arrange
+      const parsedResponses: any[] = [
+        { _id: 'field1', question: 'Question 1' },
+        { _id: 'field2', question: 'Question 2' },
+      ]
+
+      // Act
+      const actual = formatMyInfoStorageResponseData(parsedResponses)
+
+      // Assert
+      expect(actual).toEqual(parsedResponses)
+    })
+
+    it('should prefix MyInfo fields in responses when hashed fields are provided', () => {
+      // Arrange
+      const parsedResponses: any[] = [
+        {
+          _id: 'field1',
+          question: 'Question 1',
+          myInfo: { attr: 'NAME' },
+          answer: 'John Doe',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'field2',
+          question: 'Question 2',
+          answer: 'Some answer',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+          question: 'Question Child',
+          myInfo: { attr: 'childname' },
+          answer: 'Child Name',
+          fieldType: 'children',
+        },
+      ]
+      const hashedFields = new Set([
+        'field1',
+        'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+      ])
+
+      // Act
+      const actual = formatMyInfoStorageResponseData(
+        parsedResponses,
+        hashedFields,
+      )
+
+      // Assert
+      expect(actual).toEqual([
+        {
+          _id: 'field1',
+          question: '[MyInfo] Question 1',
+          myInfo: { attr: 'NAME' },
+          answer: 'John Doe',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'field2',
+          question: 'Question 2',
+          answer: 'Some answer',
+          fieldType: 'textfield',
+        },
+        {
+          _id: 'childrenbirthrecords.692411846d1da146b503aada.childname.0',
+          question: '[MyInfo] Question Child',
+          myInfo: { attr: 'childname' },
+          answer: 'Child Name',
+          fieldType: 'children',
+        },
+      ])
+    })
+  })
 })

src/app/modules/submission/encrypt-submission/encrypt-submission.utils.ts

@@ -144,19 +144,14 @@ export const formatMyInfoStorageResponseData = (
   parsedResponses: ProcessedFieldResponse[],
   hashedFields?: Set<MyInfoKey>,
 ) => {
-  console.log(`formatMyInfoStorageResponseData`)
   if (!hashedFields) {
     return parsedResponses
   } else {
     return parsedResponses.flatMap((response) => {
       if (isProcessedChildResponse(response)) {
-        console.log(`isProcessedChildResponse)`)
         return getAnswersForChild(response).map((childField) => {
-          console.log(`childField`)
-          console.log(childField)
           const myInfoPrefix = getMyInfoPrefix(childField, hashedFields)
           childField.question = `${myInfoPrefix}${childField.question}`
-          console.log(childField.question)
           return childField
         })
       } else {